Use simple_ptr_list_destroy() rather than reimplementing it#561
Closed
jeltz wants to merge 1 commit intopercona:mainfrom
Closed
Use simple_ptr_list_destroy() rather than reimplementing it#561jeltz wants to merge 1 commit intopercona:mainfrom
jeltz wants to merge 1 commit intopercona:mainfrom
Conversation
Copying the function and adding a pfree() never made any sense. But on top of this I wonder why we only free the list and not the items contained in the list.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (75.87%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 57.47% 57.47%
=======================================
Files 68 68
Lines 10709 10709
Branches 2640 2640
=======================================
Hits 6155 6155
Misses 3292 3292
Partials 1262 1262
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Ah, so the reason was that it did not exist in 17. Closing this would I rethink it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying the function and adding a
pfree()never made any sense. But on top of this I wonder why we only free the list and not the items contained in the list.