Open
Conversation
…ercona/mysqld_exporter into PMM-14958-fix-duplicate-metrics-errors
3959aba to
2749855
Compare
maxkondr
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUBMODULES-4286
This pull request enhances the support for monitoring MySQL group replication with parallel replication workers. It updates the custom queries and their corresponding tests to include the
worker_idlabel, which allows metrics to be reported separately for each replication worker thread. This change improves observability in environments where parallel replication is used.Key changes:
Custom Query Enhancements:
mysql_perf_schema_replication_group_workerandmysql_perf_schema_replication_group_worker_5queries in bothqueries-mysqld-group-replication.ymlandpercona/tests/custom-queries/high-resolution/queries-mysqld-group-replication.ymlto select and expose theworker_idfield, enabling per-worker metrics. [1] [2]worker_idlabel to the metrics definitions, with descriptions clarifying its meaning for both single-threaded and parallel replication scenarios. [1] [2]Testing Improvements:
TestScrapeCustomQueriesReplicationGroupWorkerParallelReplication) incollector/percona_custom_query_test.goto verify that metrics are correctly produced for each parallel replication worker, ensuring the newworker_idlabel is handled as expected.These changes improve the accuracy and granularity of replication monitoring for MySQL instances using group replication with parallel workers.