Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Percona-specific guided tour and several Percona navigation customizations, reverting parts of the UI back toward upstream Grafana behavior and simplifying bootstrap/navigation-related code.
Changes:
- Removed the Percona tour feature (Reactour dependency, provider, steps/messages/components, Redux state, and related styles/user flags).
- Simplified Percona bootstrapping and removed Percona navigation bootstrapping/custom menu rendering.
- Reverted/cleaned up core navigation UI customizations (mega menu item rendering, menu width, nav model extensions) and switched News drawer back to Grafana’s default feed/link.
Reviewed changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes @reactour/* and related dependencies from the lockfile. |
| package.json | Drops @reactour/tour dependency. |
| public/sass/components/_pmm_tour.scss | Removes tour-specific styling. |
| public/sass/_grafana.scss | Stops importing the removed tour Sass. |
| public/app/percona/tour/** | Deletes tour provider, components, and tour step definitions/messages. |
| public/app/percona/shared/services/user/User.types.ts | Removes tour completion fields from user details payload types. |
| public/app/percona/shared/services/user/User.service.ts | Removes API helpers that set tour completion flags. |
| public/app/percona/shared/core/selectors.ts | Removes the getTour selector. |
| public/app/percona/shared/core/reducers/user/user.utils.ts | Stops mapping tour completion flags into the user model. |
| public/app/percona/shared/core/reducers/user/user.types.ts | Removes tour completion flags from UserDetails. |
| public/app/percona/shared/core/reducers/user/user.ts | Removes tour-related thunks/state; fixes setSnoozedVersion thunk type string. |
| public/app/percona/shared/core/reducers/tour/** | Deletes tour reducer/types/index exports. |
| public/app/percona/shared/core/reducers/index.ts | Removes tour reducer wiring; import cleanup/reordering. |
| public/app/percona/shared/core/hooks/tour.ts | Deletes the custom tour hook. |
| public/app/percona/shared/components/PerconaBootstrapper/PerconaTour/** | Deletes tour bootstrapper. |
| public/app/percona/shared/components/PerconaBootstrapper/PerconaNavigation/** | Removes Percona navigation bootstrapping implementation; keeps constants export only. |
| public/app/percona/shared/components/PerconaBootstrapper/PerconaNavigation/PerconaNavigation.constants.ts | Removes Percona-only nav item props like showDot/showChildren. |
| public/app/percona/shared/components/PerconaBootstrapper/PerconaBootstrapper.tsx | Removes tour modal/bootstrapper and Percona navigation rendering; keeps updates modal gating. |
| public/app/percona/shared/components/PerconaBootstrapper/PerconaBootstrapper.messages.ts | Removes unused tour-modal strings. |
| public/app/core/components/AppChrome/News/NewsDrawer.tsx | Switches to Grafana blog link and default RSS feed constant. |
| public/app/core/components/AppChrome/MegaMenu/MegaMenuItemText.tsx | Stops using Percona variable-preserving URL helper; uses raw url for navigation/pinning. |
| public/app/core/components/AppChrome/MegaMenu/MegaMenuItem.tsx | Removes Percona dot/icon tweaks and aria-label wrapper used by tours. |
| public/app/core/components/AppChrome/MegaMenu/MegaMenu.tsx | Restores default menu width. |
| public/app/core/components/AppChrome/AppChromeMenu.tsx | Removes tour-based dismissal restrictions. |
| public/app/AppWrapper.tsx | Removes Percona tour provider wrapper. |
| packages/grafana-data/src/types/navModel.ts | Removes Percona-only extensions from NavModelItem. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
public/app/percona/shared/components/PerconaBootstrapper/PerconaBootstrapper.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14509