Skip to content

PMM-14880-rta-pmm-demo: "login as guest" #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabio-silva wants to merge 7 commits into
base: main
Choose a base branch
from
Open

PMM-14880-rta-pmm-demo: "login as guest" #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
97cd37a
feat: "login as guest"
fabio-silva Mar 19, 2026
68ef88d
chore: disable "login as guest" btn when loggin in already
fabio-silva Mar 19, 2026
9da5737
chore: prettier
fabio-silva Mar 19, 2026
0108497
chore: unit tests
fabio-silva Mar 19, 2026
80066d7
feat: use only frontend settings
fabio-silva Mar 24, 2026
21f6d96
chore: add @Percona comment
fabio-silva Mar 25, 2026
a4afedf
chore: remove test changes
fabio-silva Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/api/dtos/frontend_settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,10 @@ type FrontendSettingsDTO struct {

LicenseInfo FrontendSettingsLicenseInfoDTO `json:"licenseInfo"`

FeatureToggles map[string]bool `json:"featureToggles"`
AnonymousEnabled bool `json:"anonymousEnabled"`
FeatureToggles map[string]bool `json:"featureToggles"`
AnonymousEnabled bool `json:"anonymousEnabled"`
// @PERCONA: add anonymousOrgRole to the frontend settings
AnonymousOrgRole string `json:"anonymousOrgRole"`
AnonymousDeviceLimit int64 `json:"anonymousDeviceLimit"`
RendererAvailable bool `json:"rendererAvailable"`
RendererVersion string `json:"rendererVersion"`
Expand Down
6 changes: 4 additions & 2 deletions pkg/api/frontendsettings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,10 @@ func (hs *HTTPServer) getFrontendSettings(c *contextmodel.ReqContext) (*dtos.Fro
EnabledFeatures: hs.License.EnabledFeatures(),
},

FeatureToggles: featureToggles,
AnonymousEnabled: hs.Cfg.Anonymous.Enabled,
FeatureToggles: featureToggles,
AnonymousEnabled: hs.Cfg.Anonymous.Enabled,
// @PERCONA: add anonymousOrgRole to the frontend settings
AnonymousOrgRole: hs.Cfg.Anonymous.OrgRole,
AnonymousDeviceLimit: hs.Cfg.Anonymous.DeviceLimit,
RendererAvailable: hs.RenderService.IsAvailable(c.Req.Context()),
RendererVersion: hs.RenderService.Version(),
Expand Down
3 changes: 2 additions & 1 deletion public/app/core/components/Login/LoginCtrl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ export class LoginCtrl extends PureComponent<Props, State> {

render() {
const { children } = this.props;
const { isLoggingIn, isChangingPassword, showDefaultPasswordWarning, loginErrorMessage } = this.state;
const { isLoggingIn, isChangingPassword, showDefaultPasswordWarning, loginErrorMessage } =
this.state;
const { login, toGrafana, changePassword, passwordlessStart, passwordlessConfirm } = this;
const { loginHint, passwordHint, disableLoginForm, disableUserSignUp } = config;

Expand Down
2 changes: 1 addition & 1 deletion public/app/core/components/Login/LoginPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ jest.mock('@grafana/runtime', () => ({
}));

describe('Login Page', () => {

beforeEach(() => {
jest.resetAllMocks();
});

it('renders correctly', () => {
render(<LoginPage />);

expect(screen.getByRole('heading', { name: 'Welcome to Grafana' })).toBeInTheDocument();
expect(screen.getByRole('textbox', { name: 'Email or username' })).toBeInTheDocument();
expect(screen.getByLabelText('Password')).toBeInTheDocument();
expect(screen.getByRole('button', { name: 'Log in' })).toBeInTheDocument();
Expand Down
2 changes: 1 addition & 1 deletion public/app/core/components/Login/LoginPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const LoginPage = () => {
skipPasswordChange,
isChangingPassword,
showDefaultPasswordWarning,
loginErrorMessage,
loginErrorMessage
}) => (
<LoginLayout isChangingPassword={isChangingPassword}>
{!isChangingPassword && !showPasswordlessConfirmation && (
Expand Down
Loading