PMM-14213 Upgrade Grafana to v12.4.2 by fabio-silva · Pull Request #869 · percona/grafana

fabio-silva · 2026-01-20T12:11:27Z

.github/workflows/deploy-storybook-preview.yml

.github/workflows/frontend-lint.yml

Copilot

Pull request overview

This PR upgrades Grafana to version 12.3.1, which involves significant updates to the Advisor application's check system architecture and introduces new checks for instance, configuration, and SSO settings.

Changes:

Refactored plugin check implementation to use new plugin checker and error resolver services
Added new check types for instance attributes (version support/pinned status), configuration settings, SSO settings, and data source validation
Updated various generated code files, dependencies, and documentation to support Grafana 12.3.1

Reviewed changes

Copilot reviewed 201 out of 13286 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
apps/advisor/pkg/app/checks/plugincheck/check.go	Refactored to use new plugin checker service and error resolver instead of direct plugin installer
apps/advisor/pkg/app/checks/instancechecks/*.go	Added new checks for Grafana instance version support and cloud pinned versions
apps/advisor/pkg/app/checks/datasourcecheck/*.go	Extended data source checks with missing plugin and deprecated auth detection
apps/advisor/pkg/app/checks/configchecks/*.go	Added security configuration validation for secret keys
apps/advisor/pkg/app/checks/authchecks/*.go	Added SSO settings list format validation
apps/advisor/pkg/app/checks/ifaces.go	Updated Check and Step interfaces to include new methods and logging
apps/advisor/pkg/app/checkregistry/checkregistry.go	Updated service to wire new checks and dependencies
apps/advisor/pkg/apis/advisor/v0alpha1/*.go	Updated generated API code for new failure report fields (itemID, moreInfo)
apps/advisor/kinds/*.cue	Updated CUE schema definitions for Check and CheckType kinds
apps/advisor/go.mod	Updated Go version to 1.25.5 and numerous dependencies
Makefile	Updated Go version, build flags, Docker configuration, and testing commands
SECURITY.md, CONTRIBUTING.md, README.md	Updated documentation and security reporting guidance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/advisor/pkg/app/checks/datasourcecheck/check.go

apps/advisor/pkg/app/checks/datasourcecheck/prom_dep_auth_check_step.go

apps/advisor/pkg/app/checks/instancechecks/out_of_support_step.go

matejkubinec · 2026-02-05T14:40:44Z

Some feedback (personally for me for reviewing the upgrade the best approach is to compare with upstream). I'm using Meld, but needed to check on a linux machine, MacOS version is broken on Tahoe.

Left	Right
PMM	Grafana (upstream)

Could you replace the current docs folder with upstream one? (just a few changes there)

Check if the expander ts ignores etc. can be replaced with the ones from upstream

Check if the additional changes are needed here (doesn't seem something that we've implemented)

Same as 3., check if it's needed.

Look like the custom code is not needed anymore (there isn't a "New" badge anymore)

Add @PERCONA tag

Remove added line (if it's not a problem)

Remove comment

Remove if unused

Remove if unused

Remove if unused

Remove if unused

* chore: refactor table field selector

…rafana#117776)

* Heatmap: Prevent BucketExpansionFactor divide by 0 * Clean up comments * Fix decreasing test * Add more test coverage * Update public/app/plugins/panel/heatmap/utils.ts Co-authored-by: Paul Marbach <paul.marbach@grafana.com> --------- Co-authored-by: Paul Marbach <paul.marbach@grafana.com>

…ests (grafana#117813) Revert "Tempo: Forward incoming and team headers for streaming requests (grafana#116092)" This reverts commit cdd1130.

Co-authored-by: Adela Almasan <88068998+adela-almasan@users.noreply.github.com>

* Minor corrections * Update Getting Started tab text and docs URL in source files Move translation changes from generated locale file to source t() calls and update documentation link to point to the correct git-sync docs. --------- Co-authored-by: Clarity-89 <homes89@ukr.net>

* chore: transfer Levitate alerts * chore: fix breaking change

* Secrets: Remove contract for unimplemented keepers * also remove access key + kms key id from aws keeper

Fix "Last evaluation duration" using incorrect time unit API returns `evaluationTime` in seconds, not milliseconds.

@hugohaggmark

…17850) * Provisioning: Remove domain restrictions for GitHub, GitLab, and Bitbucket URLs Allow self-hosted instances (GitHub Enterprise, self-managed GitLab, self-hosted Bitbucket) to use provider-specific connectors instead of requiring the generic git connector. Consolidate URL validation into shared config, apply generic domain-stripping to all providers, and remove dead code. * Provisioning: Move httpUtils to api/clients/provisioning/utils Move the provisioning error helper to its new home alongside the other provisioning API client utilities. * Apply suggestion from @hugohaggmark Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com> * Stricter i18n sorting --------- Co-authored-by: Hugo Häggmark <hugo.haggmark@gmail.com> Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com>

…d the play dashboads (grafana#117637) * updated readme and added links to video and the play dashboads Added video tutorial and Grafana Play demo links to MySQL datasource README. * removed extra line Removed unnecessary line break and adjusted formatting. * Fix prettier --------- Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>

trim .git for repo url

* Provisioning: Check App permissions in tester * using app data, not installation * rollback changes * formatting * using already existing PEM * add permissions * fixing integration tests * fixing integration tests

…afana#117769) add folderUid to restoreDashboardVersion

* refactor: decouple migrators * refactor: decouple * refactor: add shorturl * fix: tests * fix: remove count resources

…y schemas) (grafana#117874) * Remove registry flow to push schemas to kind-registry * Fix codeowners * Update workspaces

…#117854) Co-authored-by: Dana Axinte <dana.axinte@grafana.com>

Co-authored-by: =?UTF-8?q?Piotr=20Jamr=C3=B3z?= <pm.jamroz@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix: don't reuse plugin config * Clean up unused named return

* Update changelog * Update version to 12.4.2 * update CHANGELOG.md --------- Co-authored-by: grafana-delivery-bot[bot] <grafana-delivery-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Minehart <5140827+kminehart@users.noreply.github.com>

Update CHANGELOG

…-14213-grafana-12.3.1

fabio-silva requested review from a team, YashSartanpara1, Copilot and matejkubinec and removed request for a team January 20, 2026 12:11

github-advanced-security bot found potential problems Jan 20, 2026

View reviewed changes

Copilot AI reviewed Jan 20, 2026

View reviewed changes

apps/advisor/pkg/app/checks/datasourcecheck/check.go Show resolved Hide resolved

apps/advisor/pkg/app/checks/datasourcecheck/prom_dep_auth_check_step.go Show resolved Hide resolved

apps/advisor/pkg/app/checks/instancechecks/out_of_support_step.go Show resolved Hide resolved

JNKPercona mentioned this pull request Feb 9, 2026

chore: grafana 12.3.1 Percona-Lab/pmm-submodules#4198

Draft

1 task

gtk-grafana and others added 21 commits February 10, 2026 22:12

Logs Table: Logs options sidebar (grafana#117447)

939456f

* chore: refactor table field selector

Provisioning: retrieve default branch for Git repos in Test endpoint (g…

1859e97

…rafana#117776)

Tempo: Remove forwarding incoming and team headers for streaming requ…

f073f64

…ests (grafana#117813) Revert "Tempo: Forward incoming and team headers for streaming requests (grafana#116092)" This reverts commit cdd1130.

Playlists: Add frontend fallback to v0alpha1 (grafana#117822)

3756fb9

Co-authored-by: Adela Almasan <88068998+adela-almasan@users.noreply.github.com>

chore: replace config.panels usage in codeLoader (grafana#117678)

3f8e7e0

chore: transfer Levitate alerts (grafana#117851)

2c55a32

* chore: transfer Levitate alerts * chore: fix breaking change

Secrets: Remove contract for unimplemented keepers (grafana#117765)

2d7628f

* Secrets: Remove contract for unimplemented keepers * also remove access key + kms key id from aws keeper

fix(apps/live): update go.sum (grafana#117855)

bdef438

Alerting: Fix alert rule last evaluation duration units (grafana#117814)

7de9550

Fix "Last evaluation duration" using incorrect time unit API returns `evaluationTime` in seconds, not milliseconds.

Provisioning: Pure Git URL trim .git suffix (grafana#117815)

963e62a

trim .git for repo url

Provisioning: Check Github App permissions in tester (grafana#117762)

f071832

* Provisioning: Check App permissions in tester * using app data, not installation * rollback changes * formatting * using already existing PEM * add permissions * fixing integration tests * fixing integration tests

RestoreDashboardVersion: Add folderUid to restoreDashboardVersion (gr…

ec4cc4a

…afana#117769) add folderUid to restoreDashboardVersion

refactor: decouple resource migrators from accessor (grafana#117743)

c03d2bd

* refactor: decouple migrators * refactor: decouple * refactor: add shorturl * fix: tests * fix: remove count resources

Codegen: Remove registry flow to push schemas to kind-registry (legac…

b26eb58

…y schemas) (grafana#117874) * Remove registry flow to push schemas to kind-registry * Fix codeowners * Update workspaces

Security: Use dashboard timerange if time selection disabled (grafana…

e97fa5f

…#117854) Co-authored-by: Dana Axinte <dana.axinte@grafana.com>

Security: Sanitize TraceView html (grafana#117853)

8dfa644

Co-authored-by: =?UTF-8?q?Piotr=20Jamr=C3=B3z?= <pm.jamroz@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Fix: Don't reuse go-plugin config (grafana#117877)

7c395fc

* Fix: don't reuse plugin config * Clean up unused named return

fabio-silva and others added 24 commits March 25, 2026 17:06

chore: remove tour

40c8247

Release: 12.4.2 (grafana#121092)

a095a3a

* Update changelog * Update version to 12.4.2 * update CHANGELOG.md --------- Co-authored-by: grafana-delivery-bot[bot] <grafana-delivery-bot[bot]@users.noreply.github.com> Co-authored-by: Kevin Minehart <5140827+kminehart@users.noreply.github.com>

chore: remove changes related to side menu

afb522b

chore: remove percona code on NewsDrawer

0a90e5a

[release-12.4.2] Update CHANGELOG (grafana#121186)

5d05f18

Update CHANGELOG

chore: remove further unused code

21224e8

chore: prettier

1c8bc4e

Merge branch 'main' into PMM-14213-grafana-12.3.1

0a2b840

Merge remote-tracking branch 'grafana-origin/release-12.4.2' into PMM…

9770e15

…-14213-grafana-12.3.1

chore: prettier

7a1c935

fix: import

3cb6fd3

fix: unused code

ba04bf0

fix: types

25e8bd5

chore: update docs

a2f17f9

Merge branch 'PMM-14509-cleanup' into PMM-14213-grafana-12.3.1

2b12423

fix: imports

33dd7a5

Merge branch 'main' into PMM-14213-grafana-12.3.1

d630add

fix: typings

ef1d02d

fix: styles

7ac2bdf

chore: deactivate Grafana workflows

625eed9

chore: rename workflow

4a17536

chore: increase node space size for unit tests

2bec585

fix: tests

a384f78

chore: prettier

d5046a2

fabio-silva changed the title ~~PMM-14213 Upgrade Grafana to v12.3.1~~ PMM-14213 Upgrade Grafana to v12.4.2 Apr 2, 2026

fabio-silva added 5 commits April 2, 2026 14:59

chore: add comment for disabled workflows

74f9b9a

fix: duplicate key on workflow

d26de30

fix: duplicate permissions

11a0a50

chore: remove unused files from upstream

8a8736d

fix: typings

96ade5a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PMM-14213 Upgrade Grafana to v12.4.2#869

PMM-14213 Upgrade Grafana to v12.4.2#869
fabio-silva wants to merge 8440 commits intomainfrom
PMM-14213-grafana-12.3.1

fabio-silva commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matejkubinec commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

fabio-silva commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matejkubinec commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants