This repository was archived by the owner on Jan 8, 2019. It is now read-only.
Optionally create jobs from XML config instead of Template Job#15
Open
mikeocool wants to merge 1 commit intopercolate:masterfrom
Open
Optionally create jobs from XML config instead of Template Job#15mikeocool wants to merge 1 commit intopercolate:masterfrom
mikeocool wants to merge 1 commit intopercolate:masterfrom
Conversation
Member
|
@jamesob want to take a look at this? |
Contributor
|
sure. checking it out now. don't have a test environment set up though... |
Contributor
|
@mikeocool rad! this is a great change; thanks for sharing upstream. I haven't tested this branch myself (no environment readily at hand), but nothing looks out of place after a few reads. @lra or @malford may want to test this on Percolate's environment. It'd be really awesome to update README.md with information on how to use this new config option, and (potentially) a sample XML config file? |
Member
|
Cool, |
Contributor
Author
|
Yeah, I'll definitely add a sample XML and update the README shortly. |
Contributor
|
@lra Sure, will test this out this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had kind of an annoying problem that popped up when we upgrade Jenkins a few months ago; every time we pushed anything to any branch on our github repo, the Jennifer template job would start building, and then immediately fail and trigger failure notifications on our various reporters, since ${pr_branch} isn't a real branch.
I poked around in jenkins, the git plugin, and the github plugin trying to figure out how to make this stop, and it seemed like it was sort of intentional. Basically, because the git plugin can't determine if there are any changes (since ${pr_branch} doesn't exist), it says 'GAH! I can't tell if anything has changed, do a build!'
It seemed like a nice way to avoid this issue all together would be to just get rid of the the template job altogether, and create jobs from a template jenkins project XML file that lived outside of Jenkins, and thus this pull request born.