Open
Conversation
…le to build on the fly. New mm draw arg --sim. Cleaned up dead or gnarly code.
…e out CLI, refactored marble_mirror
…e out CLI, refactored marble_mirror
…rror, cli. Added local rng to camera for SimCamera
ishmandoo
reviewed
Sep 2, 2022
ishmandoo
previously approved these changes
Sep 2, 2022
ishmandoo
reviewed
Sep 2, 2022
| from marble_mirror.hardware.gate import PiGate | ||
| from marble_mirror.hardware.camera import PiCamera | ||
| from marble_mirror.hardware.gcode import PiGCodeBoard | ||
| from marble_mirror.mirror import MarbleMirror, Elevator |
There was a problem hiding this comment.
Could you sort Elevator before MarbleMirror please?
ishmandoo
reviewed
Sep 2, 2022
| # https://github.com/gnea/grbl/wiki/Grbl-v1.1-Commands#x---kill-alarm-lock | ||
| self.write("$X") | ||
|
|
||
| # def __del__(self): |
There was a problem hiding this comment.
Please make sure to read your PRs before you submit them and delete any dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.