feat(creation): Implement joint account creation flow #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasin-ce
force-pushed
the
multisig/06-account-pages-support
branch
from
4b6f926 to
f44cf3b
Compare
yasin-ce
force-pushed
the
multisig/07-creation-flow
branch
from
5b34bb9 to
9fa3c15
Compare
yasin-ce
force-pushed
the
multisig/06-account-pages-support
branch
from
f44cf3b to
c787611
Compare
yasin-ce
force-pushed
the
multisig/07-creation-flow
branch
from
9fa3c15 to
91daf6f
Compare
- Fix duplicate DI bindings for joint account repository - Add missing interface implementations - Update transaction signer handling for joint accounts - Fix import statements and code organization
- Add CreateJointAccountFragment and ViewModel - Add NameJointAccountFragment for account naming - Add AddJointAccountFragment for participant selection - Implement JointAccountTransactionSignHelper - Add CreateJointAccountUseCase - Add participant selection UI components - Handle contact creation for external addresses
- Update AccountAssetsFragment to use onInboxClick - Update AccountAssetsAccountDetailAdapter to call listener.onInboxClick - Update AccountDetailQuickActionsView to match Inbox sealed class
yasin-ce
force-pushed
the
multisig/06-account-pages-support
branch
from
c787611 to
8bd9179
Compare
yasin-ce
force-pushed
the
multisig/07-creation-flow
branch
from
91daf6f to
ab2aecc
Compare
…ation-flow * multisig/06-account-pages-support: fix(di): Add missing GetJointAccount and GetJointAccountParticipantCount bindings fix(test): Use correct domain model class names in HasInboxItemsForAddressUseCaseTest
Architecture: - app module (UI only): Fragments, Screens, ViewModels that use interfaces - common-sdk domain layer (public): UseCase interfaces, Domain models - common-sdk data layer (internal): Repository (internal), UseCase implementations, Services, Mappers Changes: - Make JointAccountRepository internal - Create use case interfaces for each repository function: - CreateJointAccount - GetInboxMessages - DeleteInboxJointInvitationNotification - Create internal use case implementations - Delete duplicate data layer from app module - Update app module to use common-sdk use cases - Add Dagger bindings for new use cases
Fix Fragment lifecycle violations where initSavedStateListener was called in onResume instead of onViewCreated: - ContactInfoFragment: Remove duplicate call in onResume (was in both) - AccountHistoryFragment: Move to onViewCreated - Arc59SendSummaryFragment: Move to onViewCreated, remove empty onResume - InAppPinFragment: Move to onViewCreated, remove empty onResume This ensures SavedState listeners are registered early in the lifecycle and prevents missing initial state emissions.
…tion The existing GetInboxMessages in InboxUseCases.kt gets cached data. The new FetchInboxMessages fetches from the API via repository.
- Replace *DTO suffix with actual domain model names - ParticipantSignatureDTO -> ParticipantSignature - JointSignRequestDTO -> JointSignRequest - SignRequestWithFullSignatureDTO -> SignRequestWithFullSignature - TransactionListWithFullSignatureDTO -> TransactionListWithFullSignature - SignRequestTransactionListResponseDTO -> AddSignatureInput - Fix PeraResult.Success/Error usage in DefaultJointAccountDetailProcessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AddAccountIntroFragmentwith create joint account optionNameJointAccountFragmentfor account namingAddJointAccountFragmentfor participant selectionSetThresholdFragmentfor threshold configurationCreateJointAccountFragmentfor final creationCreateJointAccountUseCasewith validationJointAccountInfoDialogfor feature explanationJointAccountSignRequestFragmentfor sign request handlingPendingSignaturesBottomSheetfor signature statusJointAccountLedgerSignHelperfor Ledger device signingTest Plan