feat(ui): Add joint account support to existing account screens #516

yasin-ce · 2026-01-20T09:23:39Z

Summary

Add AccountIconResource.JOINT with dedicated icon styling
Add JointAccountBadgeViewHolder for account list items
Add JointAccountDetailFragment and JointAccountDetailScreen
Add JointAccountDetailViewModel with processor pattern
Update GetAccountIconDrawablePreview for joint accounts
Update account detail summary for joint accounts
Add export/share account fragment

Test Plan

Verify joint account displays correct icon in account list
Verify joint account badge shows participant count
Verify joint account detail screen shows all participants
Test navigation to joint account detail

- Update AccountIconResource with JOINT type - Add joint account badge to account list items - Update account detail screens for joint accounts - Add joint account icon drawable preview - Update account type detection in existing flows - Add TransactionSigner.Joint handling

…-support Resolve merge conflicts: - DefaultAccountDetailAccountsItemProcessor: keep 06's joint account features with HasInboxItemsForAddress - AccountStatusDetailPreviewDecider: keep 06's proper Joint account handling - Restore use cases removed by merge: GetJointAccount, GetJointAccountUseCase, GetJointAccountParticipantCount, GetJointAccountParticipantCountUseCase - Update DefaultJointAccountDetailProcessor to use InboxMessages instead of InboxMessagesDTO

- Add internal modifier to AssetInboxRepositoryImplTest - Update HasInboxItemsForAddressUseCaseTest to use AssetInbox and JointAccount instead of DTO versions

…-support

@provides

…unt bindings Add Dagger @provides methods for GetJointAccount and GetJointAccountParticipantCount use cases in JointAccountModule to fix missing binding errors.

mitsinsar · 2026-01-22T14:27:02Z

...in/com/algorand/wallet/jointaccount/domain/usecase/GetJointAccountParticipantCountUseCase.kt

+    override suspend fun invoke(address: String): Int {
+        val jointAccount = getLocalAccount(address) as? LocalAccount.Joint
+        return jointAccount?.participantAddresses?.size ?: 0
+    }


This should be done in repository. JointAccountRepository can return this value. No need to use getLocalAccount

mitsinsar · 2026-01-22T14:27:30Z

...dk/src/main/kotlin/com/algorand/wallet/jointaccount/domain/usecase/GetJointAccountUseCase.kt

+) : GetJointAccount {
+
+    override suspend fun invoke(address: String): LocalAccount.Joint? {
+        return getLocalAccount(address) as? LocalAccount.Joint


JointAccountRepository can return this instead of calling getLocalAccount

mitsinsar · 2026-01-22T14:31:29Z

...nd/android/modules/accountdetail/jointaccountdetail/viewmodel/JointAccountDetailViewModel.kt

+            val participants: List<JointAccountParticipantItem>,
+            val participantAddresses: List<String>,


Are these contain the same addresses? If so, we shouldn't use different parameters for them

mitsinsar · 2026-01-22T14:33:09Z

...nd/android/modules/accountdetail/jointaccountdetail/viewmodel/JointAccountDetailViewModel.kt

+        stateDelegate.updateState { contentState }
+    }
+
+    private suspend fun getInvitationData(): JointAccountDetailProcessor.InvitationData? {


This function name is not only doing what it is supposed to do, it also updates state.

mitsinsar · 2026-01-22T14:36:15Z

.../accountdetail/jointaccountdetail/domain/usecase/CreateJointAccountParticipantItemUseCase.kt

+    private val contactRepository: ContactRepository
+) : CreateJointAccountParticipantItem {
+
+    override suspend fun getLocalAccountAddresses(): List<String> {


There is no point of this function. We can inject getLocalAccountAddresses into where we call this function.

mitsinsar · 2026-01-22T14:37:55Z

...odules/accountdetail/jointaccountdetail/domain/usecase/JointAccountInboxOperationsUseCase.kt

+class JointAccountInboxOperationsUseCase @Inject constructor(
+    private val deviceIdUseCase: DeviceIdUseCase,
+    @param:Named(JointAccountRepository.INJECTION_NAME)
+    private val jointAccountRepository: JointAccountRepository,
+) {
+
+    fun getDeviceId(): String? = deviceIdUseCase.getSelectedNodeDeviceId()


Unnecessary use case

mitsinsar · 2026-01-22T14:38:11Z

...orand/android/modules/accountdetail/jointaccountdetail/ui/model/JointAccountDetailUiState.kt

+
+package com.algorand.android.modules.accountdetail.jointaccountdetail.ui.model
+
+data class JointAccountDetailUiState(


Unused class

mitsinsar · 2026-01-22T14:40:22Z

...m/algorand/android/modules/accountdetail/jointaccountdetail/ui/JointAccountDetailFragment.kt

+    override fun onEditAddressClick(address: String) {
+        viewModel.onEditContactClick(address)
+    }
+
+    override fun onCopyAddressClick(address: String) {
+        onAccountAddressCopied(address)
+    }
+
+    override fun onIgnoreClick() {
+        viewModel.onIgnoreClick()
+    }
+
+    override fun onAddClick() {
+        viewModel.onAddClick()
+    }


We can do these viewmodel calls in screen composable, since we already pass viewmodel. There is no value of sending these events to Fragment and call VM function.

mitsinsar · 2026-01-22T14:41:50Z

app/src/main/kotlin/com/algorand/android/sharedpref/InboxLastOpenedTimeLocalSource.kt

+import javax.inject.Inject
+
+// ISO-8601 ISO_DATE_TIME
+class InboxLastOpenedTimeLocalSource @Inject constructor(


Please use PersistentCacheProvider instead of shared pref local source

mitsinsar · 2026-01-22T14:44:29Z

app/src/main/kotlin/com/algorand/android/core/transaction/JointAccountTransactionSignHelper.kt

+        val eligibleSigners = participantAddresses.mapNotNull { address ->
+            allLocalAccounts.find { it.algoAddress == address }
+        }.filter { localAccount ->
+            localAccount is LocalAccount.Algo25 || localAccount is LocalAccount.HdKey
+        }


Unnecessary iterations. Can be use single iteration. Also we can create a db query instead of getting all the accounts every single time

@Suppress

…-support * multisig/05-data-models: Address PR #515 comments for data models Fix detekt issues without @Suppress Fix pre-existing detekt issues Use Go SDK for transaction signing and return signature directly fix: Address remaining PR #514 review comments fix: Address PR #514 review comments fix: Address PR #514 feedback docs: Add refactoring restrictions to prevent unwanted changes

yasin-ce requested review from mitsinsar and wjbeau as code owners January 20, 2026 09:23

yasin-ce self-assigned this Jan 20, 2026

yasin-ce force-pushed the multisig/05-data-models branch from 014714a to c3e316e Compare January 20, 2026 09:32

yasin-ce force-pushed the multisig/06-account-pages-support branch from 4b6f926 to f44cf3b Compare January 20, 2026 09:32

yasin-ce force-pushed the multisig/05-data-models branch from c3e316e to 6b1b4d5 Compare January 20, 2026 09:48

yasin-ce force-pushed the multisig/06-account-pages-support branch from f44cf3b to c787611 Compare January 20, 2026 09:49

yasin-ce force-pushed the multisig/05-data-models branch from 6b1b4d5 to a997278 Compare January 20, 2026 13:49

yasin-ce force-pushed the multisig/06-account-pages-support branch from c787611 to 8bd9179 Compare January 20, 2026 13:49

yasin-ce added 4 commits January 22, 2026 14:00

Fix rule violations on branch 06

778d3f0

- Add internal modifier to AssetInboxRepositoryImplTest - Update HasInboxItemsForAddressUseCaseTest to use AssetInbox and JointAccount instead of DTO versions

Merge branch 'multisig/05-data-models' into multisig/06-account-pages…

6673043

…-support

fix(di): Add missing GetJointAccount and GetJointAccountParticipantCo…

a6f9d9f

…unt bindings Add Dagger @provides methods for GetJointAccount and GetJointAccountParticipantCount use cases in JointAccountModule to fix missing binding errors.

mitsinsar requested changes Jan 22, 2026

View reviewed changes

yasin-ce added 3 commits January 23, 2026 10:48

Normalize joint participant storage and address PR comments

bc2a582

Fix tests for normalized database schema

d414b74

yasin-ce requested a review from mitsinsar January 23, 2026 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): Add joint account support to existing account screens #516

feat(ui): Add joint account support to existing account screens #516

Uh oh!

yasin-ce commented Jan 20, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

mitsinsar Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		val participants: List<JointAccountParticipantItem>,
		val participantAddresses: List<String>,


		package com.algorand.android.modules.accountdetail.jointaccountdetail.ui.model

		data class JointAccountDetailUiState(

feat(ui): Add joint account support to existing account screens #516

Are you sure you want to change the base?

feat(ui): Add joint account support to existing account screens #516

Uh oh!

Conversation

yasin-ce commented Jan 20, 2026

Summary

Test Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants