feat(deeplink): Add joint account deep link handling and transaction DTOs #513

yasin-ce · 2026-01-20T09:23:07Z

Summary

Implement JointAccountImportDeepLinkBuilder for sharing joint accounts
Add joint sign request DTOs (JointSignRequestDTO, ProposeJointSignRequestDTO)
Add sign request transaction models and mappers
Add AddJointAccountSignature, ProposeJointSignRequest use cases
Add unit tests for deep link builders and DTO mappers

Test Plan

Verify deep link generation produces valid URLs
Verify deep link parsing extracts correct parameters
Run unit tests for transaction mappers

- Implement joint account import deep link parser - Add deep link navigation to joint account screens - Add unit tests for deep link builders - Add unit tests for joint account mappers - Add unit tests for repository implementations

…onse - Delete AssetInboxRequestMapperImplTest.kt - Delete AssetInboxRepositoryImplTest.kt - Delete AssetInboxCacheManagerImplTest.kt These tests reference AssetInboxRequestResponse which no longer exists.

mitsinsar · 2026-01-21T09:37:48Z

...-sdk/src/main/kotlin/com/algorand/wallet/algosdk/transaction/sdk/SignHdKeyTransactionImpl.kt

+        key: Int
+    ): ByteArray? {
+        return try {
+            val xHDWalletAPI = XHDWalletAPIAndroid(seed)


If Joint account needs to sign multiple transactions, this implementation will create multiple XHDWalletApiAndroid object and this may cause memory exception. If that's not the case, this should be fine since GC cleans it automatically, but if we are using this function in an iteration, we need to change it. Create wallet by using AlgorandBip39WalletProvider then sign the transaction with the same object, instead of creating new one.

mitsinsar · 2026-01-21T09:38:23Z

.../main/kotlin/com/algorand/wallet/asset/assetinbox/data/mapper/AssetInboxRequestMapperImpl.kt

-            )
-        }.orEmpty()
+        return emptyList()
+        TODO("Implement the mapper ")


Just a reminder. Ignore if this is fixed in other PRs

mitsinsar · 2026-01-21T09:55:02Z

...otlin/com/algorand/wallet/jointaccount/transaction/data/model/ParticipantSignatureRequest.kt

 import com.google.gson.annotations.SerializedName

-internal data class AssetInboxRequestResponse(
+data class ParticipantSignatureRequest(


Since this is a data model, it should be internal

mitsinsar · 2026-01-21T09:55:14Z

...in/com/algorand/wallet/jointaccount/transaction/data/model/ProposeJointSignRequestRequest.kt

+
+import com.google.gson.annotations.SerializedName
+
+data class ProposeJointSignRequestRequest(


Since this is a data model, it should be internal

mitsinsar · 2026-01-21T09:55:58Z

.../kotlin/com/algorand/wallet/jointaccount/transaction/data/model/SearchSignRequestsRequest.kt

+
+import com.google.gson.annotations.SerializedName
+
+data class SearchSignRequestsRequest(


Since this is a data model, it should be internal

mitsinsar · 2026-01-21T10:24:28Z

...kotlin/com/algorand/wallet/jointaccount/transaction/data/mapper/JointSignRequestDTOMapper.kt

+import com.algorand.wallet.jointaccount.transaction.domain.model.SignRequestStatus
+import javax.inject.Inject
+
+class JointSignRequestDTOMapper @Inject constructor(


This mapper in data package and maps domain model. It should implement public interface and then it should be internal.

mitsinsar · 2026-01-21T10:25:04Z

...src/main/kotlin/com/algorand/wallet/jointaccount/domain/repository/JointAccountRepository.kt

+    ): PeraResult<List<JointSignRequestDTO>>
+
+    companion object {
+        const val INJECTION_NAME: String = "jointAccountRepositoryInjectionName"


There is no need to use injection name if there is only one instance of JointAccountRepository to provide.

mitsinsar · 2026-01-21T10:25:26Z

common-sdk/src/main/kotlin/com/algorand/wallet/jointaccount/di/JointAccountModule.kt

+    }
+
+    @Provides
+    @Singleton


Unnecessary singleton object

mitsinsar · 2026-01-21T10:25:35Z

...-sdk/src/main/kotlin/com/algorand/wallet/jointaccount/data/service/JointAccountApiService.kt

+import retrofit2.http.POST
+import retrofit2.http.Path
+
+interface JointAccountApiService {


Should be internal

mitsinsar · 2026-01-21T10:26:53Z

...c/main/kotlin/com/algorand/wallet/jointaccount/data/repository/JointAccountRepositoryImpl.kt

+                        android.util.Log.w(
+                            "JointAccountRepository",
+                            "Failed to map sign request: id=${response.id}"
+                        )


If this is unexpected and important, we should use pera error logger instead of console logging

…link Resolves merge conflicts and applies data layer visibility rules: - Restore DTOs (domain models needed by public repository interface) - Make API service internal - Make data layer mappers internal - Make request/response models internal

- Rename JointAccountDTO → JointAccount - Rename CreateJointAccountDTO → CreateJointAccountInput - Rename JointSignRequestDTO → JointSignRequest - Rename ParticipantSignatureDTO → ParticipantSignature - Rename ProposeJointSignRequestDTO → CreateSignRequestInput - Rename SearchSignRequestsDTO → SearchSignRequestsInput - Rename SignRequestTransactionListResponseDTO → AddSignatureInput - Rename SignRequestWithFullSignatureDTO → SignRequestWithFullSignature Also rename related mappers to match new domain model names: - ProposeJointSignRequestDTOMapper → CreateSignRequestInputMapper - SearchSignRequestsDTOMapper → SearchSignRequestsInputMapper - SignRequestTransactionListResponseDTOMapper → AddSignatureInputMapper Update all usages across repository, use cases, and tests. Mock JointAccountDTOMapper in JointSignRequestMapperTest per PR review. Use companion object for test constants per PR review.

Create JointAccountTransactionUseCases.kt containing all use case interfaces (AddJointAccountSignature, GetSignRequestWithSignatures, ProposeJointSignRequest) per PR review feedback. Keep implementation classes in their own files.

Per PR review, use cases that just delegate to repository are simplified: - AddJointAccountSignature: provided directly via DI lambda - ProposeJointSignRequest: provided directly via DI lambda - GetSignRequestWithSignatures: mapping logic moved to repository Changes: - Add getSignRequestWithSignatures() to JointAccountRepository - Move mapping logic to JointAccountRepositoryImpl - Remove searchSignRequests() from public interface (internal only) - Delete use case implementation classes - Delete use case tests (logic now covered by repository) - Update DI module to provide interfaces via lambdas

Follow project rule: "One public class/interface per file"

New rules based on PR review feedback: Data Layer: - Data models (Request/Response) must be internal Domain Layer: - Domain models do NOT use DTO suffix - Use descriptive input/output naming (*Input suffix) UseCase Pattern: - Avoid unnecessary use case implementations - Provide simple use cases via DI lambda - Only create implementation when there's business logic Unit Test Best Practices: - Mock ALL dependencies (don't test multiple classes) - Use companion object for test constants - Use .copy() for test variations

…MapperTest Follow the new rule: use companion object for test constants

- Add rule: avoid unnecessary @before setup - Use inline initialization for simple mocks - Only use @before for dispatchers or resettable state - Update JointSignRequestMapperTest to use inline initialization

- Simple helpers without parameters → companion object - Helpers with default parameters from constants → private function

yasin-ce requested review from mitsinsar and wjbeau as code owners January 20, 2026 09:23

yasin-ce self-assigned this Jan 20, 2026

yasin-ce force-pushed the multisig/02-data-layer branch from e196a43 to 72c4117 Compare January 20, 2026 09:31

feat(multisig): Add deep link handling and unit tests

5211943

- Implement joint account import deep link parser - Add deep link navigation to joint account screens - Add unit tests for deep link builders - Add unit tests for joint account mappers - Add unit tests for repository implementations

yasin-ce force-pushed the multisig/03-tests-and-deeplink branch from b98a876 to 5211943 Compare January 20, 2026 09:31

fix: Remove test files referencing non-existent AssetInboxRequestResp…

1c9296e

…onse - Delete AssetInboxRequestMapperImplTest.kt - Delete AssetInboxRepositoryImplTest.kt - Delete AssetInboxCacheManagerImplTest.kt These tests reference AssetInboxRequestResponse which no longer exists.

mitsinsar requested changes Jan 21, 2026

View reviewed changes

yasin-ce added 9 commits January 22, 2026 10:28

refactor: split use case interfaces into separate file

2b74223

Create JointAccountTransactionUseCases.kt containing all use case interfaces (AddJointAccountSignature, GetSignRequestWithSignatures, ProposeJointSignRequest) per PR review feedback. Keep implementation classes in their own files.

refactor: split use case interfaces into separate files

5444990

Follow project rule: "One public class/interface per file"

refactor: use companion object for test constants in JointSignRequest…

1d32293

…MapperTest Follow the new rule: use companion object for test constants

refactor: remove unnecessary @before in tests, add rule

d1d46d1

- Add rule: avoid unnecessary @before setup - Use inline initialization for simple mocks - Only use @before for dispatchers or resettable state - Update JointSignRequestMapperTest to use inline initialization

docs: clarify test helper function placement rules

dd491ea

- Simple helpers without parameters → companion object - Helpers with default parameters from constants → private function

mitsinsar self-requested a review January 22, 2026 12:10

mitsinsar approved these changes Jan 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(deeplink): Add joint account deep link handling and transaction DTOs #513

feat(deeplink): Add joint account deep link handling and transaction DTOs #513

Uh oh!

yasin-ce commented Jan 20, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

mitsinsar Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import com.google.gson.annotations.SerializedName

		data class ProposeJointSignRequestRequest(


		import com.google.gson.annotations.SerializedName

		data class SearchSignRequestsRequest(

feat(deeplink): Add joint account deep link handling and transaction DTOs #513

Are you sure you want to change the base?

feat(deeplink): Add joint account deep link handling and transaction DTOs #513

Uh oh!

Conversation

yasin-ce commented Jan 20, 2026

Summary

Test Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants