feat(data): Implement joint account data layer #512

yasin-ce · 2026-01-20T09:22:58Z

Summary

Add LocalAccount.Joint domain model with participant addresses and threshold
Add JointDao and JointEntity for local database storage
Add JointAccountRepository interface and implementation
Add joint account mappers (entity ↔ domain model)
Add GetJointAccount, GetJointAccountProposerAddress use cases
Add database migration for joint account table
Add unit tests for repository and mappers

Test Plan

Verify joint account can be saved to local database
Verify joint account can be retrieved from database
Verify mappers correctly transform data
Run unit tests: ./gradlew :common-sdk:testDebugUnitTest

- Add JointAccountRepository with API integration - Add JointSignRequest API use cases - Add JointAccountInbox API use cases - Add domain models for joint accounts (LocalAccount.Joint) - Add DTOs for API communication - Implement account type detection for joint accounts

mitsinsar · 2026-01-21T10:56:06Z

common-sdk/src/main/kotlin/com/algorand/wallet/account/detail/domain/model/AccountType.kt

+    data object Joint : AccountType
+
    companion object {
        fun AccountType.canSignTransaction(): Boolean {


Seems like it is time to move this function in AccountType interface, and let subclasses to implement

mitsinsar · 2026-01-21T11:02:05Z

common-sdk/src/main/kotlin/com/algorand/wallet/account/local/data/database/model/JointEntity.kt

+    @ColumnInfo("algo_address")
+    val algoAddress: String,
+    @ColumnInfo("participant_addresses")
+    val participantAddresses: String,


Should we consider creating new table for participant addresses? Right now we won't be able to query. This will cause us to fetch every joint account. For example displaying error when user wants to remove one of the participant accounts from the device etc.

mitsinsar · 2026-01-21T11:07:07Z

...dk/src/main/kotlin/com/algorand/wallet/account/local/data/mapper/entity/JointEntityMapper.kt

+    operator fun invoke(localAccount: LocalAccount.Joint): JointEntity
+}
+
+internal class JointEntityMapperImpl @Inject constructor(


Let's move implementation class into new file

mitsinsar · 2026-01-21T11:30:39Z

.../kotlin/com/algorand/wallet/jointaccount/creation/data/mapper/CreateJointAccountDTOMapper.kt

+import com.algorand.wallet.jointaccount.creation.domain.model.CreateJointAccountDTO
+import javax.inject.Inject
+
+class CreateJointAccountDTOMapper @Inject constructor() {


Let's make this internal and create an interface for it.

mitsinsar · 2026-01-21T11:30:53Z

...c/main/kotlin/com/algorand/wallet/jointaccount/creation/data/mapper/JointAccountDTOMapper.kt

+import com.algorand.wallet.jointaccount.creation.domain.model.JointAccountDTO
+import javax.inject.Inject
+
+class JointAccountDTOMapper @Inject constructor() {


Let's make this internal and create an interface for it.

mitsinsar · 2026-01-21T12:14:57Z

...dk/src/main/kotlin/com/algorand/wallet/jointaccount/domain/usecase/GetJointAccountUseCase.kt

+import com.algorand.wallet.account.local.domain.usecase.GetLocalAccount
+import javax.inject.Inject
+
+internal class GetJointAccountUseCase @Inject constructor(


Let's remove this usecase and use joint account repository to return local account object

mitsinsar · 2026-01-21T12:18:02Z

...in/com/algorand/wallet/jointaccount/domain/usecase/GetJointAccountParticipantCountUseCase.kt

+import com.algorand.wallet.account.local.domain.usecase.GetLocalAccount
+import javax.inject.Inject
+
+internal class GetJointAccountParticipantCountUseCase @Inject constructor(


Can be removed and handled by repository

mitsinsar · 2026-01-21T12:18:23Z

...dk/src/main/kotlin/com/algorand/wallet/jointaccount/creation/domain/model/JointAccountDTO.kt

+
+package com.algorand.wallet.jointaccount.creation.domain.model
+
+data class JointAccountDTO(


Let's remove DTO

mitsinsar · 2026-01-21T12:18:29Z

.../main/kotlin/com/algorand/wallet/jointaccount/creation/domain/model/CreateJointAccountDTO.kt

+
+package com.algorand.wallet.jointaccount.creation.domain.model
+
+data class CreateJointAccountDTO(


Let's remove DTO

mitsinsar · 2026-01-21T12:18:45Z

common-sdk/src/main/kotlin/com/algorand/wallet/account/local/data/mapper/model/JointMapper.kt

+    operator fun invoke(entity: JointEntity): LocalAccount.Joint
+}
+
+internal class JointMapperImpl @Inject constructor(


We should move this into its own file

Per PR review comments: - Split JointEntityMapper interface and impl into separate files - Split JointMapper interface and impl into separate files - Make CreateJointAccountDTOMapper internal with interface+impl pattern - Make JointAccountDTOMapper internal with interface+impl pattern - Make CreateJointAccountRequest internal - Make JointAccountResponse internal - Add DI bindings for new mapper interfaces - Update tests to use Impl classes

Per PR review: Move canSignTransaction() function from companion object to interface method with subclass implementations. - Each AccountType subtype now overrides canSignTransaction() - Removed companion object with extension function - Updated all call sites to remove companion import

Per PR review comments: - Remove GetJointAccount/GetJointAccountUseCase (use repository directly) - Remove GetJointAccountParticipantCount/GetJointAccountParticipantCountUseCase - Remove JointAccountDTO and CreateJointAccountDTO - Remove JointAccountDTOMapper and CreateJointAccountDTOMapper - Remove related tests - Update DI module

mitsinsar · 2026-01-22T11:36:46Z

.../kotlin/com/algorand/wallet/jointaccount/creation/data/mapper/CreateJointAccountDTOMapper.kt

-            version = dto.version
-        )
-    }
+internal interface CreateJointAccountDTOMapper {


Let's rename mapper same as class it maps

mitsinsar · 2026-01-22T11:36:58Z

...lin/com/algorand/wallet/jointaccount/creation/data/mapper/CreateJointAccountDTOMapperImpl.kt

+import com.algorand.wallet.jointaccount.creation.domain.model.CreateJointAccountDTO
+import javax.inject.Inject
+
+internal class CreateJointAccountDTOMapperImpl @Inject constructor() : CreateJointAccountDTOMapper {


Let's rename mapper same as class it maps

mitsinsar · 2026-01-22T11:37:21Z

...c/main/kotlin/com/algorand/wallet/jointaccount/creation/data/mapper/JointAccountDTOMapper.kt

-            )
-        }
-    }
+internal interface JointAccountDTOMapper {


Let's rename mapper same as class it maps

mitsinsar · 2026-01-22T11:37:25Z

...in/kotlin/com/algorand/wallet/jointaccount/creation/data/mapper/JointAccountDTOMapperImpl.kt

+import com.algorand.wallet.jointaccount.creation.domain.model.JointAccountDTO
+import javax.inject.Inject
+
+internal class JointAccountDTOMapperImpl @Inject constructor() : JointAccountDTOMapper {


Let's rename mapper same as class it maps

mitsinsar · 2026-01-22T11:37:46Z

common-sdk/src/main/kotlin/com/algorand/wallet/jointaccount/di/JointAccountModule.kt

    ): GetJointAccountProposerAddress = useCase
+
+    @Provides
+    fun provideCreateJointAccountDTOMapper(


Let's rename provider same as class provides

mitsinsar · 2026-01-22T11:37:49Z

common-sdk/src/main/kotlin/com/algorand/wallet/jointaccount/di/JointAccountModule.kt

+    ): CreateJointAccountDTOMapper = impl
+
+    @Provides
+    fun provideJointAccountDTOMapper(


Let's rename provider same as class provides

yasin-ce requested review from mitsinsar and wjbeau as code owners January 20, 2026 09:22

yasin-ce self-assigned this Jan 20, 2026

yasin-ce force-pushed the multisig/01-resources branch from ee276ea to 1e4e4e2 Compare January 20, 2026 09:30

yasin-ce force-pushed the multisig/02-data-layer branch from e196a43 to 72c4117 Compare January 20, 2026 09:31

mitsinsar reviewed Jan 21, 2026

View reviewed changes

yasin-ce added 4 commits January 22, 2026 09:54

Merge branch 'multisig/01-resources' into multisig/02-data-layer

08225ef

mitsinsar reviewed Jan 22, 2026

View reviewed changes

mitsinsar self-requested a review January 22, 2026 11:39

mitsinsar approved these changes Jan 22, 2026

View reviewed changes


		package com.algorand.wallet.jointaccount.creation.domain.model

		data class JointAccountDTO(


		package com.algorand.wallet.jointaccount.creation.domain.model

		data class CreateJointAccountDTO(

feat(data): Implement joint account data layer #512

Are you sure you want to change the base?

feat(data): Implement joint account data layer #512

Uh oh!

Conversation

yasin-ce commented Jan 20, 2026

Summary

Test Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants