feat(sign-data): add verifySignature function and parameter #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjbeau
requested changes
Jan 13, 2026
| **Parameters:** | ||
| - `data`: Array of arbitrary data to sign | ||
| - `signer`: Algorand address that will sign the data | ||
| - `verifySignature` (optional): If `true`, automatically detects if the account is rekeyed (has `authAddr`) and uses the `authAddr` as the signer. After signing, verifies each signature against the original data. Defaults to `false`. |
There was a problem hiding this comment.
We might want to explain the 'MX' prefix requirement? I.e. our verification is consistent with algosdk's verification? Or maybe we should verify both (i.e. prepend MX, check it, if it fails try verifying without MX prefix?)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the signing API with built-in signature validation.
verifySignaturefunction to validate signatures for arbitrary datavalidateSignatureoption tosignDatato enable automatic verification after signingverifySignature: trueis passed tosignData, it checks whether the signer address is rekeyed and, if so, sends the signing request using the auth address