Allows players to load circuits via files/json input at the module duplicator using a circuit multitool

[hyperjll]

About The Pull Request

Gives players an option to quickly load circuits they've made and saved in JSON code. It's sad there's no option to save circuits between rounds.

Why It's Good For The Game

Cuts down on a LOT of repetition in making circuits, as well as allowing players to preserve any progress they've made should a round end too quickly.

Changelog

🆑
add: Using a circuit multitool on a module duplicator allows you to load circuits via local files or JSON input.
/:cl:

[forgman6]

Hi I dont know how to comment on files but load_circuit_data() needs to be configured to sanitize external player input.
It looks like players can spawn any item by imputing the json.
code\modules\wiremod\core\duplicator.dm

/obj/item/integrated_circuit/proc/load_circuit_data(json_data, list/errors)
  var/list/general_data = json_decode(json_data)
  ... 
  var/list/external_objects = general_data["external_objects"]
	  for(var/identifier in external_objects)
		  var/list/object_data = external_objects[identifier]
		  var/type = text2path(object_data["type"])
		  if(!ispath(type))
			  LOG_ERROR(errors, "Invalid path for external object, expected a path, got [type]")
			  continue
		  var/atom/movable/object = new type(drop_location())

This needs to be fixed for the PR to work

	admin_only = general_data["admin_only"]

[hyperjll]

Got any examples for me to work with? I'd prefer having the code look like something the maintainers want as opposed to whatever code spaghetti I might cook up.

[forgman6]

Ill check tomorrow, maybe

[forgman6]

I didnt see anything I liked, but heres some things it should do.

• use safe_json_decode instead of json_decode
• limit text input to 1000 chars. Remove fileinput option.
• to sanitize, remove anything thats not alphanumeric or syntax, do this before json decode
• create a new proc load_circuit_data_external, and rename load_circuit_data to load_circuit_data_internal so they aren't confused
• admin_only should always be false
• instead of creating components and programming them, make it so you still have to add components manually, but you can program them with the tool