Add support for Volume FX and BASSLoud #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ce4a631.
Fix `ChannelReferences` attempting JIT compilation on .NET iOS
bdach
reviewed
Apr 5, 2024
Comment on lines
720
to
748
| /// <summary> | ||
| /// BassLoud add-on: Loudness in LUFS of the last 400ms or the duration (in milliseconds) specified in the HIWORD | ||
| /// </summary> | ||
| BassLoudnessCurrent = 0, | ||
|
|
||
| /// <summary> | ||
| /// BassLoud add-on: Integrated loudness in LUFS. This is the average since measurement started. | ||
| /// </summary> | ||
| BassLoudnessIntegrated = 1, | ||
|
|
||
| /// <summary> | ||
| /// BassLoud add-on: Loudness range in LU. | ||
| /// </summary> | ||
| BassLoudnessRange = 2, | ||
|
|
||
| /// <summary> | ||
| /// BassLoud add-on: Peak level in linear scale. | ||
| /// </summary> | ||
| BassLoudnessPeak = 4, | ||
|
|
||
| /// <summary> | ||
| /// BassLoud add-on: True peak level in linear scale. | ||
| /// </summary> | ||
| BassLoudnessTruePeak = 8, | ||
|
|
||
| /// <summary> | ||
| /// BassLoud add-on: Automatically free the measurement when the channel is freed. | ||
| /// </summary> | ||
| BassLoudnessAutofree = 0x8000, |
There was a problem hiding this comment.
- broken indentation
- bit flag enums should use compile-time constant expressions with bit shifts or hex/binary literals
Author
There was a problem hiding this comment.
Addressed 1
The rest of the file doesn't seem to do 2, I believe that we should stay consistent. Either we change everything, or nothing.
mcendu
reviewed
May 1, 2024
Remove BASS_Loudness from names and change to PascalCase
hwsmm
reviewed
May 12, 2024
smoogipoo
reviewed
May 12, 2024
Changed these for internal testing and forgot to revert, oops
the project fails to load otherwise (i have no idea why lol)
Author
|
BassLoud support has been merged into upstream ManagedBass#124 There are some differences (mainly with the function names) between the BassLoud bindings in this PR and upstream. Should we switch to match upstream or continue with our implementation? |
|
We should probably just use upstream. |
Author
|
I'll close this PR and create a new one getting this fork up to date with upstream. There's a couple of changes I want to make to upstream as well, so I'll submit those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for ppy/osu#27793
Adds support for Volume Fx and Bassloud. Merges ManagedBass#124 and ManagedBass#121 with some custom bug fixes and patches to make them work. Also gets this branch up to date with ManagedBass master. Tested and works on MacOS and Windows
Another prerequisite for my PR is updated
ppy.ManagedBass.*nuget packages, so if you can, please upload updated versions of the following packages if & when this gets merged: