Upgrade to .NET 10 / Add Infinity.Toolkit.Azure#13
Merged
Conversation
- Updated `Scalar.AspNetCore` to v2.8.8 and `Microsoft.Azure.AppConfiguration.AspNetCore` to v8.4.0. - Replaced `AzureCliCredential` with `ChainedTokenCredential` in `Program.cs`. - Added `app.UseAzureAppConfiguration()` middleware for better integration. - Changed `GlobalKeyFilter` in `appsettings.json` to an empty string. - Refactored `TokenCredential` initialization in `AzureAppConfigSettings`. - Enhanced `ConfigureAzureAppConfiguration` to improve endpoint resolution and key filtering logic.
Updated .NET version to 10.0.x in build pipeline and added multi-targeting for net10.0 across projects. Enhanced EnvironmentHelper and TokenCredentialHelper for better Azure environment detection and credential management. Updated NuGet package versions and repository URLs. Refactored feature modules and improved logging. Removed legacy ServiceCollectionExtensions and cleaned up code. Upgraded test dependencies and SDK.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to .NET 10, updates Azure integration packages, and refactors credential management and configuration handling for improved Azure service authentication.
- Upgraded target frameworks from .NET 9 to .NET 10 (with multi-targeting for backward compatibility)
- Updated Microsoft package dependencies to version 9.0.10 and Azure packages to latest versions
- Refactored Azure credential handling to distinguish between Azure-hosted and local development scenarios
- Simplified configuration section naming and improved error handling for Azure App Configuration
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/nuget-publish.yml | Added .NET 10 SDK setup and removed --no-build flag from pack command |
| Directory.Build.props | Made copyright year dynamic and corrected repository URLs |
| tests/Infinity.Toolkit.Tests/Infinity.Toolkit.Tests.csproj | Upgraded to .NET 10 and updated test SDK version |
| src/Infinity.Toolkit/Infinity.Toolkit.csproj | Bumped version and updated package dependencies |
| src/Infinity.Toolkit/EnvironmentHelper.cs | Replaced Azure-specific checks with Kubernetes and Docker Desktop detection |
| src/Infinity.Toolkit.*/**.csproj | Updated target frameworks and package versions across all projects |
| src/Infinity.Toolkit.Azure/Identity/TokenCredentialHelper.cs | Refactored to conditionally use different credential chains based on Azure environment |
| src/Infinity.Toolkit.Azure/EnvironmentHelper.cs | Added new helper class for Azure environment detection |
| src/Infinity.Toolkit.Azure/Configuration/ConfigurationBuilderExtensions.cs | Changed namespace, updated configuration section name, and improved endpoint resolution logic |
| src/Infinity.Toolkit.FeatureModules/* | Updated interface signatures to use IHostApplicationBuilder and added duplicate module registration check |
| samples/* | Updated package versions and sample configuration to use ChainedTokenCredential |
Comments suppressed due to low confidence (1)
src/Infinity.Toolkit.Azure/Configuration/ConfigurationBuilderExtensions.cs:1
- Changing the default value of UseKeyVault from true to false is a breaking change that may affect existing deployments relying on the previous default behavior. Consider documenting this change or adding migration guidance.
using Azure.Core;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Infinity.Toolkit.Azure/Configuration/ConfigurationBuilderExtensions.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Classification
Upgrade to .NET 10 and refactor for improved configuration and credential management.
PR Summary
This pull request upgrades the project to .NET 10, updates package dependencies, and refactors configuration and credential handling for better Azure integration.
dotnet pack.TokenCredentialhandling to useChainedTokenCredential.