Skip to content

Upgrade to .NET 10 / Add Infinity.Toolkit.Azure#13

Merged
penyland merged 3 commits intomainfrom
azure-package
Oct 21, 2025
Merged

Upgrade to .NET 10 / Add Infinity.Toolkit.Azure#13
penyland merged 3 commits intomainfrom
azure-package

Conversation

@penyland
Copy link
Owner

PR Classification

Upgrade to .NET 10 and refactor for improved configuration and credential management.

PR Summary

This pull request upgrades the project to .NET 10, updates package dependencies, and refactors configuration and credential handling for better Azure integration.

  • nuget-publish.yml: Updated to use .NET 10 and modified the build process to include the build step in dotnet pack.
  • Directory.Build.props: Set copyright year dynamically and updated repository URLs.
  • Program.cs: Refactored TokenCredential handling to use ChainedTokenCredential.
  • ConfigurationBuilderExtensions.cs: Changed namespace and updated configuration section handling.
  • EnvironmentHelper.cs: Added to detect Azure environment execution contexts.

- Updated `Scalar.AspNetCore` to v2.8.8 and `Microsoft.Azure.AppConfiguration.AspNetCore` to v8.4.0.
- Replaced `AzureCliCredential` with `ChainedTokenCredential` in `Program.cs`.
- Added `app.UseAzureAppConfiguration()` middleware for better integration.
- Changed `GlobalKeyFilter` in `appsettings.json` to an empty string.
- Refactored `TokenCredential` initialization in `AzureAppConfigSettings`.
- Enhanced `ConfigureAzureAppConfiguration` to improve endpoint resolution and key filtering logic.
Updated .NET version to 10.0.x in build pipeline and added multi-targeting for net10.0 across projects. Enhanced EnvironmentHelper and TokenCredentialHelper for better Azure environment detection and credential management. Updated NuGet package versions and repository URLs. Refactored feature modules and improved logging. Removed legacy ServiceCollectionExtensions and cleaned up code. Upgraded test dependencies and SDK.
Copilot AI review requested due to automatic review settings October 21, 2025 19:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to .NET 10, updates Azure integration packages, and refactors credential management and configuration handling for improved Azure service authentication.

  • Upgraded target frameworks from .NET 9 to .NET 10 (with multi-targeting for backward compatibility)
  • Updated Microsoft package dependencies to version 9.0.10 and Azure packages to latest versions
  • Refactored Azure credential handling to distinguish between Azure-hosted and local development scenarios
  • Simplified configuration section naming and improved error handling for Azure App Configuration

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
.github/workflows/nuget-publish.yml Added .NET 10 SDK setup and removed --no-build flag from pack command
Directory.Build.props Made copyright year dynamic and corrected repository URLs
tests/Infinity.Toolkit.Tests/Infinity.Toolkit.Tests.csproj Upgraded to .NET 10 and updated test SDK version
src/Infinity.Toolkit/Infinity.Toolkit.csproj Bumped version and updated package dependencies
src/Infinity.Toolkit/EnvironmentHelper.cs Replaced Azure-specific checks with Kubernetes and Docker Desktop detection
src/Infinity.Toolkit.*/**.csproj Updated target frameworks and package versions across all projects
src/Infinity.Toolkit.Azure/Identity/TokenCredentialHelper.cs Refactored to conditionally use different credential chains based on Azure environment
src/Infinity.Toolkit.Azure/EnvironmentHelper.cs Added new helper class for Azure environment detection
src/Infinity.Toolkit.Azure/Configuration/ConfigurationBuilderExtensions.cs Changed namespace, updated configuration section name, and improved endpoint resolution logic
src/Infinity.Toolkit.FeatureModules/* Updated interface signatures to use IHostApplicationBuilder and added duplicate module registration check
samples/* Updated package versions and sample configuration to use ChainedTokenCredential
Comments suppressed due to low confidence (1)

src/Infinity.Toolkit.Azure/Configuration/ConfigurationBuilderExtensions.cs:1

  • Changing the default value of UseKeyVault from true to false is a breaking change that may affect existing deployments relying on the previous default behavior. Consider documenting this change or adding migration guidance.
using Azure.Core;

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@penyland penyland merged commit c238eec into main Oct 21, 2025
2 checks passed
@penyland penyland deleted the azure-package branch October 21, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants