feat(files): add secure WEBP image upload support #468 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohilPrajapati
commented
Dec 20, 2025
RohilPrajapati
commented
- Add WEBP magic number detection (RIFF....WEBP)
- Validate filename and binary signature match
- Prevent spoofed image uploads
- Add comprehensive WEBP test coverage
- Add WEBP magic number detection (RIFF....WEBP) - Validate filename and binary signature match - Prevent spoofed image uploads - Add comprehensive WEBP test coverage
wmnnd
reviewed
Dec 20, 2025
test/keila/files/files_test.exs
Outdated
| # Store a file | ||
| {:ok, file} = | ||
| Files.store_file(project.id, @test_file, filename: "keila.png", type: "image/png") | ||
| Files.store_file(project.id, @test_file_webp, filename: "keila.webp", type: "image/webp") |
Contributor
There was a problem hiding this comment.
It doesn't make sense to use the webp file specifically here, please revert this line.
Author
There was a problem hiding this comment.
Reverted changes as per feedback.
Contributor
|
Thank you for this PR! It does what it says it does and I'd be happy to merge it! Before I can merge it though, please apply the small fix I added as a review comment and also sign the CLA. You can read how that works here: https://github.com/pentacent/keila/blob/main/.cla/README.md |
wmnnd
approved these changes
Dec 26, 2025
wmnnd
force-pushed
the
main
branch
2 times, most recently
from
f9adb61 to
455250a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.