Open
Conversation
Member
jeofo
commented
Sep 5, 2024
jeofo
commented
- BREAKING: update to python3.12—remove pipenv and reinstall
- Removed scripts (@joyliu-q can we remove some k8 stuff now?)
- Cleaned up database implementation
- Cron job now scheduled via FastAPI Server
- General bugfixes
Member
Author
|
TODO: Update CI/CD to 3.12 |
Contributor
|
@JeffersonDing you want to try your hand at Kittyhawk (remove the K8s stuff in |
Member
Author
Yeah, I'll try 😔 |
joyliu-q
reviewed
Sep 6, 2024
Contributor
joyliu-q
left a comment
joyliu-q
left a comment
There was a problem hiding this comment.
Coming along nicely! You should try your hands at the /k8s stuff, it's written in TS and meant to be easily configured.
| end = time.time() | ||
| runtime = end - start | ||
| print(f"Time taken: {runtime} seconds") | ||
| assert runtime < BENCHMARK_TIME |
Contributor
There was a problem hiding this comment.
Any reason we removed this assertion?
Member
Author
There was a problem hiding this comment.
I'll add it back, was trying to make tests pass
| @repeat_at(cron="0 0 * * *") | ||
| async def flush_db(): | ||
| count = await redis_count() | ||
| print(f"{count} items found in redis") |
Contributor
There was a problem hiding this comment.
Instead of printing these, let's use Python's logging, and set an overall logger with some settings.
| json_string = json.dumps(data) | ||
| data = json.loads(json.loads(json_string)) | ||
| except ValueError as e: | ||
| print(e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.