fix: treat querySelector/querySelectorAll as methods in untainted proto…#67
Merged
pendo-ops merged 1 commit intopendo-mainfrom Mar 16, 2026
Merged
Conversation
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
megboehlert
approved these changes
Mar 16, 2026
guntherjh
approved these changes
Mar 16, 2026
guntherjh
left a comment
guntherjh
left a comment
There was a problem hiding this comment.
LGTM. Damn we definitely should send this upstream. I can't imagine the excessive iframe creation is helping with performance at all.
|
[merge] |
|
Branch jc-queryselector-as-methods deleted |
juliecheng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…type check
issue:
querySelectorandquerySelectorAllwere listed astestableAccessors= the checks always failed = we're always creating/removing iframes to try and get the untainted versions when it's not necessaryfix:
move both
querySelectorandquerySelectorAllintotestableMethods