NOVUS-391 Defer custom element registration to consumer#2
Open
NOVUS-391 Defer custom element registration to consumer#2
Conversation
Add parseAction() method to support multiple action formats:
- Array: [{"action":"submit-poll"},{"action":"dismiss"}]
- Object: {"action":"go-to-step","stepId":"abc"}
- String with param: go-to-step:abc123
- Simple string: dismiss
handleClick() now emits {actions: [...]} array instead of single action,
enabling composable multi-action buttons without combinatorial explosion
of composite action cases.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move all customElements.define() calls out of individual component files into an exported registerGuideComponents() function. This prevents NotSupportedError when the plugin script is loaded twice (e.g. staging), since the consumer controls when registration happens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
customElements.define()side-effect calls from individual component filessrc/register.jsexportingregisterGuideComponents()which registers all elements with acustomElements.get()guardregisterGuideComponents()when ready (e.g. in plugininitialize())This fixes a
NotSupportedErrorin staging where the html-guides plugin script loads twice, causing double registration of custom elements.Test plan
registerGuideComponents()before instantiating elements)NotSupportedErrorwhen plugin script loads twice🤖 Generated with Claude Code