Open
Conversation
Add parseAction() method to support multiple action formats:
- Array: [{"action":"submit-poll"},{"action":"dismiss"}]
- Object: {"action":"go-to-step","stepId":"abc"}
- String with param: go-to-step:abc123
- Simple string: dismiss
handleClick() now emits {actions: [...]} array instead of single action,
enabling composable multi-action buttons without combinatorial explosion
of composite action cases.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mdellanoce
approved these changes
Mar 10, 2026
| * - "previous-step" - Go back to previous step | ||
| * - "dismiss" - Close the guide | ||
| * - "link:URL" - Open a URL | ||
| * - "launch-guide:GUIDE_ID" - Launch another guide |
There was a problem hiding this comment.
if the actions are already objects, might as well split this up and have keys for the other parameters, e.g. { action: 'launch-guide', guideId: 'GUIDE_id' }
There was a problem hiding this comment.
looking further down, seems it might already do that, and the comment is just a little out of date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parseAction() method to support multiple action formats:
handleClick() now emits {actions: [...]} array instead of single action, enabling composable multi-action buttons without combinatorial explosion of composite action cases.