This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Open
Conversation
811951a to
2a0ffbe
Compare
sgp
suggested changes
Sep 3, 2024
Contributor
sgp
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mibanescu)
error_reporting_test.go line 173 at r1 (raw file):
} func (e *ErrorReportingTest) TestCriticalf_Ignores(c *C) {
I think maybe your test for "Ignores" is not in the right test (by its name).
2a0ffbe to
febbf48
Compare
sgp
approved these changes
Sep 3, 2024
Contributor
sgp
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mibanescu)
Contributor
|
JIRA status checks failed:
|
febbf48 to
4e26e51
Compare
Contributor
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
4e26e51 to
cce1573
Compare
Contributor
|
Failed pendo.io/jira-ref check. Please correct Jira references in the following commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is