Skip to content
This repository was archived by the owner on Jul 3, 2025. It is now read-only.

APP-108640 Added ignoredCriticalfPatterns#176

Open
mibanescu wants to merge 1 commit intomasterfrom
mihai-app-108640
Open

APP-108640 Added ignoredCriticalfPatterns#176
mibanescu wants to merge 1 commit intomasterfrom
mihai-app-108640

Conversation

@mibanescu
Copy link
Copy Markdown
Contributor

@mibanescu mibanescu commented Sep 3, 2024

This change is Reviewable

Copy link
Copy Markdown
Contributor

@sgp sgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mibanescu)


error_reporting_test.go line 173 at r1 (raw file):

}

func (e *ErrorReportingTest) TestCriticalf_Ignores(c *C) {

I think maybe your test for "Ignores" is not in the right test (by its name).

Copy link
Copy Markdown
Contributor

@sgp sgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: [merge]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mibanescu)

@pendo-ops
Copy link
Copy Markdown
Contributor

pendo-ops commented Sep 3, 2024

JIRA status checks failed:

  • APP-108640: Invalid state 'Backlog' for merge into master

@pendo-ops
Copy link
Copy Markdown
Contributor

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

4e26e51

@pendo-ops
Copy link
Copy Markdown
Contributor

Failed pendo.io/jira-ref check. Please correct Jira references in the following commits:

cce1573

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants