Skip to content

Fix for kernel 6.12 and newer #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonnyTech wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix for kernel 6.12 and newer #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d17c976
Fix for kernel 6.11 and newer
JonnyTech Dec 28, 2024
54e70dd
Merge pull request #1 from JonnyTech/JonnyTech-kernel611
JonnyTech Dec 28, 2024
bee0af7
Fix for kernel 6.12 and newer
JonnyTech Jan 22, 2025
a3176ae
Correctly handle omen key signal
JonnyTech Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
install:
dkms install .
modprobe hp-wmi

uninstall:
dkms remove hp-omen-wmi/0.9 --all
rmmod hp_wmi || true
dkms remove hp-omen-wmi/0.9 --all || true
rm /var/lib/dkms/hp-omen-wmi/0.9/source || true
rm -rf /usr/src/hp-omen-wmi-0.9 || true
rm -rf /var/lib/dkms/hp-omen-wmi || true
rm /usr/lib/modules/*-amd64/kernel/drivers/platform/x86/hp/hp-wmi.* || true

all: install

20 changes: 14 additions & 6 deletions src/hp-wmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,24 +544,32 @@ static DEVICE_ATTR_RO(dock);
static DEVICE_ATTR_RO(tablet);
static DEVICE_ATTR_RW(postcode);

static void hp_wmi_notify(u32 value, void *context)
#define AE_KEY_OMEN EXCEP_ENV (0x1001)

static void hp_wmi_notify(union acpi_object *obj, void *context)
{
struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
u32 event_id, event_data;
union acpi_object *obj;
acpi_status status;
u32 *location;
int key_code;

status = wmi_get_event_data(value, &response);
// Replace wmi_get_event_data with acpi_evaluate_object
char method[16];
snprintf(method, sizeof(method), "_WED"); // Replace "_WED" with the actual ACPI method if different
status = acpi_evaluate_object(NULL, method, NULL, &response);

if (status == AE_NOT_FOUND)
{
// We've been woken up without any event data
// Some models do this when the Omen hotkey is pressed
event_id = HPWMI_OMEN_KEY;
}
else if (status == AE_KEY_OMEN) {
event_id = HPWMI_OMEN_KEY;
}
else if (status != AE_OK) {
pr_info("bad event value 0x%x status 0x%x\n", value, status);
pr_info("bad event value 0x%x status 0x%x\n", 0, status);
return;
}
else
Expand Down Expand Up @@ -1173,7 +1181,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
return err;
}

static int __exit hp_wmi_bios_remove(struct platform_device *device)
static void __exit hp_wmi_bios_remove(struct platform_device *device)
{
int i;
cleanup_sysfs(device);
Expand All @@ -1196,7 +1204,7 @@ static int __exit hp_wmi_bios_remove(struct platform_device *device)
rfkill_destroy(wwan_rfkill);
}

return 0;
// return 0;
}

static int hp_wmi_resume_handler(struct device *device)
Expand Down