Upgrade for solc 0.4.16 and TestRPC v4.1.3#13
Open
craig-ludington wants to merge 1 commit intopelle:masterfrom
Open
Upgrade for solc 0.4.16 and TestRPC v4.1.3#13craig-ludington wants to merge 1 commit intopelle:masterfrom
craig-ludington wants to merge 1 commit intopelle:masterfrom
Conversation
* Solc ** The format of the JSON emitted by solc changed between version 0.4.1 and 0.4.16. The keys for contracts used to be the contract name but now they include the file name. Old: "SimpleToken", new: "path/to/SimpleToken:SimpleToken". ** cloth.contracts/compile-solidity accepts the newer version of solc JSON output ** The new version of compile-solidity accepts solc 0.4.1 output as well as 0.4.16 output. ** There's an optional compile-solidity argument, `ignore-warnings?` that treats the compilation as successful when there are warnings but solc exit status is zero. If solc returns a non-zero status, compile-solidity fails either way. * TestRPC ** The default `testrpc` gasPrice is very large (20000000000) which caused many test failures. Some failed due to out-of-gas errors. Others failed because they explicitly tested for gasPrice of 1. ** Starting TestRPC with `--gasPrice 1` allows the tests to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and 0.4.16. The keys for contracts used to be the contract name but
now they include the file name. Old: "SimpleToken", new: "path/to/SimpleToken:SimpleToken".
JSON output
as 0.4.16 output.
ignore-warnings?thattreats the compilation as successful when there are warnings but solc
exit status is zero. If solc returns a non-zero status,
compile-solidity fails either way.
testrpcgasPrice is very large (20000000000) whichcaused many test failures. Some failed due to out-of-gas errors.
Others failed because they explicitly tested for gasPrice of 1.
--gasPrice 1allows the tests to pass.