-
Notifications
You must be signed in to change notification settings - Fork 15
snowflakes: Remove enabled switch & Translate #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThese changes remove the SNOWFLAKES_ENABLED configuration option and replace hard-coded UI labels with internationalization (i18n) translation keys across the snowflakes plugin, consolidating configuration data retrieval to use a single Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
snowflakes/lang/en/strings.php (1)
1-14: LGTM with optional wording refinement.The translation file structure is correct and provides clear English strings for all snowflakes UI elements.
Consider refining line 11 for clarity:
- 'density_help' => 'Page density of the snowflakes. More density, more snowflakes.', + 'density_help' => 'Number of snowflakes on the page. Higher values show more snowflakes.',
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
snowflakes/config/snowflakes.phpsnowflakes/lang/en/strings.phpsnowflakes/src/Providers/SnowflakesPluginProvider.phpsnowflakes/src/SnowflakesPlugin.php
💤 Files with no reviewable changes (1)
- snowflakes/config/snowflakes.php
🔇 Additional comments (5)
snowflakes/src/SnowflakesPlugin.php (4)
29-73: LGTM! Translation keys are consistent.All slider labels and help text correctly use translation keys from
snowflakes::strings.*that match the keys defined in the new translation file.
29-73: Well-structured settings form.The slider configurations are well-defined with appropriate ranges, steps, and consistent structure. Each slider properly retrieves defaults from the config file and includes helpful tooltips.
83-91: LGTM!The settings save implementation is straightforward, properly persisting configuration to environment variables and providing user feedback via notification.
88-88: No issue found — translation pattern is correct for plugins.This is a plugin that references translations from the parent Pelican Panel application, which is the standard pattern across this plugin repository. Other plugins (generic-oidc-providers, legal-pages, player-counter) similarly reference
admin/*translation keys that are not defined in their own language files. Theadmin/setting.save_successkey is expected to be provided by the Pelican Panel core, not by the plugin itself.snowflakes/src/Providers/SnowflakesPluginProvider.php (1)
29-29: I need you to provide the review comment that needs to be rewritten. Please share the original review comment within<review_comment>tags, along with any relevant context about the codebase or file being reviewed, so I can verify the concerns and rewrite the comment accordingly.
The switch doesn't do anything anyway, if you don't want snowflakes anymore disable the plugin.

Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.