Run Libpostal as child process #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
libpostal_child_process
branch
from
d91a0ed to
3eca6ea
Compare
missinglink
force-pushed
the
libpostal_child_process
branch
from
3eca6ea to
39d4dc7
Compare
Member
|
Interesting! Does this have any advantages over using HTTP? |
Member
Author
|
Yet to be determined, it certainly wasn't the silver bullet I was hoping it would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much inspired by the PR to use libpostal over an HTTP API and the great thing is it uses the same
async/awaitAPI.So all methods are interchangeable, be it
sync,async,child_processorhttp.This PR moves the loading of
libpostalto a child module and creates a message bus that can be shared in a multi-threaded environment.