fix(ci): resolve ESLint parsing errors for test files#33
Open
fix(ci): resolve ESLint parsing errors for test files#33
Conversation
The CI lint job fails because parserOptions.project points to tsconfig.json, which explicitly excludes *.test.ts files. ESLint's typescript parser cannot resolve type information for test files, causing 4 parsing errors. Create tsconfig.eslint.json that extends the base config but includes test files. Point ESLint's parserOptions.project to this new config. Also fix unused variable errors: - Prefix catch clause variable with underscore (_userinfoError) - Prefix side-effect-only variable with underscore (_server) - Add varsIgnorePattern and caughtErrorsIgnorePattern to the no-unused-vars rule to match the existing argsIgnorePattern - Add missing @eslint/js devDependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsconfig.eslint.jsonthat includes test files, fixing 4 ESLint parsing errorsparserOptions.projectto the new tsconfigvarsIgnorePatternandcaughtErrorsIgnorePatternto no-unused-vars rule@eslint/jsdevDependencyRoot Cause
tsconfig.jsonexcludes**/*.test.ts(correct for build), but ESLint'sparserOptions.projectpointed to it, making type-aware linting impossible for test files.Test plan
pnpm exec eslint src/succeeds locally with 0 errors