Adds getPaymentMethods, saveInvoice, getTags, getSevUsers, getContactAddresses, getStaticCountries, getParts #2
Conversation
jondewoo
changed the title
jondewoo
changed the title
jondewoo
changed the title
jondewoo
changed the title
|
Awesome! Going to review it this week. Sorry for the delay :) |
jhnns
left a comment
jhnns
left a comment
There was a problem hiding this comment.
Awesome! Thank you for contributing new methods :)
The code itself looks good. You stick to the existing conventions 👍
Also thank you for adding tests ❤️
Unfortunately, we can't execute mutations in our CI system because we don't have a dedicated test system for SevDesk :(. We have the same problem with the addDocument() method.
Until we have a dedicated test system, these tests need to be skipped and can only be executed in manual tests. I tried to change your PR but it seems like I can't push changes to your main branch. Better create dedicated PR branches in your fork next time 😁
That's why I created a follow-up PR with your commits and my changes: #3
| } | ||
| if (response.ok === false || error) { | ||
| const message = error?.message ?? body?.error?.message; | ||
| const message = error?.message ?? body?.error?.message ?? body.message; |
There was a problem hiding this comment.
Seriously? 😁 They also return just {"message": "..."}?
2 participants
No description provided.