Refactor useInfiniteScroll: remove cancelled flag and simplify fetch handling#21
Merged
pedrokarim merged 1 commit intomainfrom Mar 15, 2026
Merged
Refactor useInfiniteScroll: remove cancelled flag and simplify fetch handling#21pedrokarim merged 1 commit intomainfrom
pedrokarim merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the cleanup logic in the
useInfiniteScrollhook by removing the unnecessarycancelledflag and its associated cleanup function. Instead, it relies solely on thefetchGenRefgeneration check to prevent state updates from outdated fetches.Improvements to infinite scroll cleanup logic:
cancelledflag and cleanup function from the effect, streamlining the logic and reducing potential sources of bugs. Now, only thefetchGenRefgeneration check is used to prevent state updates from stale fetches. (hooks/use-infinite-scroll.ts) [1] [2]