Refactor infinite scroll logic: update fetchMore to return hasMore and add setHasMore for better state management#19
Merged
pedrokarim merged 1 commit intomainfrom Mar 15, 2026
Merged
Conversation
…d add setHasMore for better state management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the infinite scroll and data refresh logic in the gallery page to improve reliability and avoid unnecessary re-renders. The main changes involve switching from direct state dependencies to using refs for asynchronous functions and state, and updating the
useInfiniteScrollhook API for better control and consistency.Infinite scroll and data fetching improvements:
useInfiniteScrollhook now expectsfetchMoreto return an object with{ data, hasMore }instead of just an array, and takes aninitialHasMoreprop instead ofhasMore. It exposes a newsetHasMoremethod to update the "has more" state from the parent when needed. [1] [2]Gallery page (
GalleryClient) logic updates:fetchFilesandresetare now routed through refs (fetchFilesRef,resetRef) to prevent stale closures and unnecessary effect dependencies, leading to more predictable and performant updates. [1] [2] [3] [4] [5]setHasMoremethod fromuseInfiniteScrollto control pagination state after filters, uploads, or refreshes, ensuring correct behavior when the data set changes. [1] [2] [3] [4]These changes collectively make the infinite scroll and data refresh logic more robust, maintainable, and less prone to subtle bugs caused by stale closures or unnecessary re-renders.