Merged
Conversation
xvfb-run fails silently in Docker due to stale lock files, causing the container to exit without ever starting Node. Start Xvfb manually in the background with lock file cleanup, then exec node.
router and t were recreated every render, causing fetchAlbumData to loop. Use refs to break the dependency cycle, matching the gallery page fix.
- Recent skins: server-side JSON storage (50 max, FIFO, deduped by UUID) with GET/POST API routes and auto-save on search - Featured skins: NameMC trending scraper with 24h cache and manual fallback list of well-known players - API health indicator: polling dot (green/yellow/red) with tooltip in the search bar showing render API availability - API documentation page at /tools/minecraft-skin/api with endpoint cards, parameter tables, cURL examples and JSON responses - i18n translations (EN/FR) for all new UI strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the Minecraft Skin tool, focusing on new features for displaying and managing featured and recently searched skins, as well as improved API health monitoring and documentation. The changes include new backend API routes, UI components for recent/featured skins, and localization updates.
New features for Minecraft Skin tool:
SkinThumbnailGrid) and logic to fetch, display, and interact with these lists inpage.client.tsx. Users can now see trending skins and their recent searches, and select them to quickly view details. [1] [2] [3] [4] [5] [6] [7]Backend API additions:
featured/route.ts), recent skins (recent/route.ts), and API health (health/route.ts). Also supports adding a new recent skin via POST. [1] [2] [3]Localization and documentation:
Technical improvements:
AlbumViewClient, ensuring correct routing and translation behavior. (app/(app)/albums/[id]/page.client.tsxL3-R3, app/(app)/albums/[id]/page.client.tsxR52-R58, app/(app)/albums/[id]/page.client.tsxL78-R100, app/(app)/albums/[id]/page.client.tsxL110-R129)These changes collectively provide a richer user experience for the Minecraft Skin tool, making it easier to discover trending skins, revisit recent searches, and understand the API's capabilities and status.