Alternative solution for listAll method.#38
Merged
pedr0limpio merged 1 commit intomainfrom Jul 2, 2025
Merged
Conversation
silrenan
changed the title
silrenan
changed the title
pedr0limpio
approved these changes
Jul 2, 2025
Owner
pedr0limpio
left a comment
pedr0limpio
left a comment
There was a problem hiding this comment.
Approved with reservations, because even when there is no task or when the DB is "offline", the application does not return errors.
|
|
||
| while (rs.next()) { | ||
| Task task = new Task(); | ||
| int taskId = rs.getInt("task_id"); |
Owner
There was a problem hiding this comment.
Okay, here we come to the part of incorporating GraphQL good practice into the code.
…nd add listAll() endpoint with corresponding test Signed-off-by: silrenan <75952546+silrenan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to introduces an alternative approach to address the same problem targeted by the original branch. The branch was duplicated to explore a different solution.