Impling Support

[pandahacker]

Added Implings to event scouting. Does not include Puro Puro or the list of crystal impling variants

[peanubnutter]

I agree with default false, otherwise everyone who has currently downloaded this might start suddenly sending impling events without their consent. Also, implings by their nature are competitive unlike forestry events, so there is a disincentive to sharing impling events.

[pandahacker]

Yeah.. I didnt want to step on any toes with that logging discord. There is a group of us trying to help out scouting for someone else and with the custom endpoint I have it sending to a discord webhook on another server. Might be useful to others that get it but let me know if you have any advice. Its just hard to get a group to trust shadow jars 😅

[pandahacker]

Should I maybe add another field for impEventEndpoint? So that it wouldnt hit yours if someone does check that box?

[peanubnutter]

Yeah, agreed. I think that could kill two birds with one stone: 1) Allowing people to use a different server for Forestry vs. Implings, and 2) allowing people to use the "main" server but create private scouting groups.

[peanubnutter]

Could you also add toggles for each imp type to the config? e.g. BabyImpEnabled. It could cut down on the amount of traffic sent. Maybe everything Dragon + above would be on by default.

[peanubnutter]

Thanks for this. I have a few additional questions / comments:

1. Have you heard of the Impling Finder plugin? https://runelite.net/plugin-hub/show/impling-finder. Is it still working properly? Its existence is why I haven't yet considered adding implings to this plugin. I'd like to ask what the differences and benefits are of adding implings to this plugin as well.

2. Implings are competitive in nature, unlike forestry, so I wasn't sure people would actually want to submit implings or not. I considered adding a config option for a "group name", similar to the party hub plugin, so that users can have their own secret impling scouting groups. For example, their group name is "password123", and they submit implings to "/calls/password123" and get the list from "/calls/password123". Or if they leave the group blank, then it defaults to the "public" "/calls" like all of the forestry events.

3. Did you try testing this? I don't see any IMP types submitted to the server.

4. Could you give some more information about the crystal impling issue? Do you plan to add crystal implings support in the future? It seems like the crystal impling NPC ID is added to the list, so I'm not sure why it wouldn't work.

5. How are you preventing puro puro implings from being submitted? Do they have a different NPC ID than overworld implings of the same type?

[peanubnutter]

Currently, the NPC ID is sent to the server, but it's not exposed when actually reading the data (https://g98c6e9efd32fb1-scouting.adb.us-ashburn-1.oraclecloudapps.com/ords/scouting/calls/).

So we need to do 1 of 2 things:

1. Create a unique event type per imp type instead of mapping all NPCs to the same event type, or
2. expose NPC ID on the server side

To determine which of these is best, I think we'd need to know: Is it ever possible for multiple NPC IDs to map to the same imp type? (e.g. multiple different types of crystal implings which have different NPC IDs).

[pandahacker]

Kind of. Most implings have two different IDs based on if they are in Puro Puro or not. Im like 90% sure based on only me testing.

As far as the crystal ones Im a bit more unsure since there are so many entries in the runelite api

[peanubnutter]

Maybe you could just add them all and see what happens. Hah. Up to you.

I still think it might be better to map the impling IDs to a logical name so that people don't have to look up all the numbers to figure out which one is which.

[pandahacker]

1. It does work properly. Main difference is Impling Finder only looks for Magpie's or higher and is prone to submitting duplicate entries.

2. Honestly I think that having a separate endpoint for them would be ideal as Im assuming most people that would use this would have volunteer scouts for them. They bring their own endpoint and the plugin would just give them JSON data. (Im currently using Huginn to handle Imp type identification based on npc_id)

3. I didnt want to hit your server so Ive been testing with my own server and it works
   
   Which gets forwarded to discord using some shopify liquid tricks
   

4. I could add crystal impling support in the future. its mostly the crystal impling spawns in prif have various ids attached to them.

5. Puro Puro Implings have their own unique npc ids that have a string of numbers at the end