Skip to content

Conversation

@pcuste1
Copy link
Owner

@pcuste1 pcuste1 commented Apr 21, 2025

What is changing?

  • Utilizes new "regionSelected" listener callback. This callback returns the type of the region drawn (circle, poly, or rect) as well as coordinates needed to define each of the regions. This is used by the python widget to create an astropy Region.
  • Utilize new aladin.selectRegion to select objects by a predefined region

why is this needed?

  • This API will be used by ipyaladin to give users programmatic access to the selection capabilities of aladin-lite. Users will be able to draw a selection in the aladin-lite widget, export that region, and then import it at a later time. This can aid in repeatability of notebook workflows, the saving of complex selections, and the linking of selection events across different tools to enable scientists needs.

related PRs

aladin-lite

Future work

  • Expose models from aladin-lite for the different regions so that there is ensure consistency between these two packages
  • Ensure that the math all works out for the different regions. Rectangles in particular might still need a little attention

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pcuste1
Copy link
Owner Author

pcuste1 commented Apr 30, 2025

note: This PR is going to fail builds until the related aladin-lite PR is merged and used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants