-
Notifications
You must be signed in to change notification settings - Fork 2
feat: NRT support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Nullable Reference Types (NRT) support to the FBus library by enabling nullable annotations and updating the codebase to be compatible with nullable reference types.
- Added NRT support through
Directory.Build.propsconfiguration - Refactored message interfaces by introducing a base
IMessageinterface - Updated type annotations throughout the codebase to properly handle null values
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Enables nullable reference types for the entire project |
| FBus/FBus.fs | Refactors message interfaces and adds nullable annotations to core types |
| FBus/Control.fs | Updates message handling logic with proper null handling patterns |
| FBus/Serializers.fs | Removes explicit type annotation from Serialize method parameter |
| FBus.RabbitMQ7/Transport.fs | Adds null checking for RabbitMQ headers |
| FBus.Json/Serializer.fs | Updates serialization with null checking |
| FBus.GenericHost/Container.fs | Updates container interface with nullable return types |
| FBus.Extensions.Tests/FBusExtensions.cs | Updates C# interface implementations with nullable annotations |
| Multiple test files | Updates message types to implement new interface hierarchy |
| Multiple sample files | Updates consumers and message types for new interface structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.