alert-fix for reoccuring alerts for unfinished tasks

[jbsmith7741]

PR Type

Bug fix, Enhancement

---

Description

• Rename GetTaskSummaryByDate to GetTaskRecapByDate for clarity

• Remove 1-day time constraint from incomplete task alert detection

• Fix whitespace and formatting inconsistencies across multiple files

• Improve code style with proper indentation and blank line handling

---

Diagram Walkthrough

flowchart LR
  A["Incomplete Task Detection"] -->|Remove 1-day constraint| B["Alert Query Logic"]
  C["Method Rename"] -->|GetTaskSummaryByDate to GetTaskRecapByDate| D["Handler Update"]
  E["Code Formatting"] -->|Whitespace cleanup| F["Multiple Files"]

Loading

File Walkthrough

	Relevant files
Enhancement	1 files handler.go Update method call to renamed function                                      +2/-2
Formatting	9 files alerts.go Remove trailing blank lines                                                            +0/-2      dates.go Add trailing newline for consistency                                          +1/-0      dbstats.go Remove trailing blank lines                                                            +0/-2      files.go Add trailing newline for consistency                                          +1/-0      sqlite.go Add trailing newline for consistency                                          +1/-0      sqlite_test.go Fix import spacing and indentation                                              +5/-4      stats.go Fix whitespace and blank line inconsistencies                        +7/-7      workflow.go Remove trailing whitespace                                                              +1/-1      workflow_test.go Fix test case formatting and indentation                                  +1/-2
Bug fix	1 files tasks.go Remove 1-day time constraint from incomplete task alerts  +3/-6

---

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Error logging context: New call to GetTaskRecapByDate logs a generic error without user context or action details, which may limit audit usefulness though it is internal logging. Referred Code taskStats, err := tm.taskCache.GetTaskRecapByDate(dt) summaryTime := time.Since(summaryStart) if err != nil { log.Printf("Error getting task summary: %v", err) taskStats = sqlite.TaskStats{} Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Alert join scope: Removing the 1-day constraint from the alert join may flood alerts for very old incomplete tasks without additional throttling or safeguards shown in the diff. Referred Code rows, err := s.db.Query(` SELECT tr.id, tr.type, tr.job, tr.info, tr.result, tr.meta, tr.msg, tr.created, tr.started, tr.ended FROM task_records tr LEFT JOIN alert_records ar ON ( tr.id = ar.task_id AND tr.type = ar.task_type AND tr.job = ar.job AND ar.msg LIKE 'INCOMPLETE:%' ) WHERE tr.created < ? AND tr.result = '' AND ar.id IS NULL Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Log message content: The added error log for task summary may include error details from storage/DB; while no PII is logged here, verify upstream errors do not include sensitive data. Referred Code if err != nil { log.Printf("Error getting task summary: %v", err) taskStats = sqlite.TaskStats{} Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

No code suggestions found for the PR.