Fix default values for Orca GoTo120Hz mode#2
Open
bhill-slac wants to merge 1 commit intopcdshub:masterfrom
Open
Fix default values for Orca GoTo120Hz mode#2bhill-slac wants to merge 1 commit intopcdshub:masterfrom
bhill-slac wants to merge 1 commit intopcdshub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During Orca V3 testing Mike Skoufis and I discovered that the default values for the
GoTo120Hz sequence were wrong. This is because the appropriate defaults
were determined during early testing and autosaved on the few IOCs that we used to test and deploy Orca cameras.
Thus no one noticed this problem till Mike created a new Orca IOC.
Motivation and Context
I don't know of an open issue re this.
How Has This Been Tested?
Tested using Mike's test IOC.
Where Has This Been Documented?
Pre-merge checklist