I_1217 Source unavailable in some cases for submissions from API and a primary.#1218
Open
johnbrvc wants to merge 2 commits intopc2ccs:developfrom
Open
I_1217 Source unavailable in some cases for submissions from API and a primary.#1218johnbrvc wants to merge 2 commits intopc2ccs:developfrom
johnbrvc wants to merge 2 commits intopc2ccs:developfrom
Conversation
Fix EventFeedUtilities.java to ignore zip file names that are empty or are directories (end in a /). CI: Somewhat related, but do not create a zip file for an API submission source file request with entries that have empty filenames.
Fix errant comment. Change overrideSubmissionID to default of 0 since a submissions can not have an ID of 0. A negative submission ID is special and will get converted to a positive number, so -1 is really submission 1.
JoeTerlizzi
approved these changes
Feb 12, 2026
Collaborator
JoeTerlizzi
left a comment
There was a problem hiding this comment.
Ran according to instructions with success.
Windows 11
Change the doplayback1.bat from ${subfile} to %subfile%
Make note for users to delete or edit their .netrc file to use admin logins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Fix
EventFeedUtilities.javato ignore zip file names that are empty or are directories (end in a /).CI: Somewhat related, but do not create a zip file for an API submission source file request with entries that have empty filenames.
CI: Fix errant comment.
CI: Change
overrideSubmissionIDto default of 0 since a submission will not have an ID of 0. A negative submission ID is special and will get converted to a positive number, so -1 is really submission 1, hence we can't use that as a default.Issue which the PR addresses
#1217
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Windows 11
java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)
Linux Ubuntu 24.04.3 (for testing)
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)
pr1217files.zip) file into a new directory someplace convenient. BTW, you'll need python3 installed for this test procedure to work, otherwise --- you're on your own.pr1217files.zip
pc2ef) or from eclipse, just start a pc2 client and use the login ef1.~/.netrcfile is located (either$HOME/.netrcon Linux orC:\Users\USERNAME\.netrcon Windows)pr1217file.zipfile.doplayback1.sh(Linux) ordoplayback1.bat(Windows). This will make a submission using the1.zipfile included inpr1217file.zip.1.zipcontains a hierarchy which aggravated the bug previously.