I1006 Merge in i1006_update_prs branch with WTI fixes for point scoring#1211
Merged
johnbrvc merged 75 commits intoi1006_point_scoringfrom Jan 31, 2026
Merged
I1006 Merge in i1006_update_prs branch with WTI fixes for point scoring#1211johnbrvc merged 75 commits intoi1006_point_scoringfrom
johnbrvc merged 75 commits intoi1006_point_scoringfrom
Conversation
The wrong variable (siteString) was used when setting a new institution for a team while processing accounts_load.tsv. The correct variable should be value from the column where the institution id is stored, values[institutionCodeColumn].
Added a contest that includes teams that have institution names.
Fix TabSeparatedValueParser to allow backslash escaping of characters in fields. CI: Allow the timelimit in the CLICS section to be a Double (SEERC contest did this) CI: Add better exception handling if invalid institution information is returned
Fixed NPE added by adding Double processing.
…thub.com/clevengr/pc2v9.git into i1083_F5_in_WTI_fails_with_remote_server
page saving is not needed due to the restructuring with APP_INITIALIZER -- AppInit automatically uses the browser's most-recent page URL.
add support for better handling of Run/Clar popup notifications.
reorganize imports and exports for clarity.
the WTI-UI Angular code needs an iterable (such as an array) in order to iterate over team elements.
added additional fields isSolved and isFinal to UI-side Run class so that these missing fields are available for future use.
additional updates including: - unsubscribing runspage from filter changes when appropriate; - resetting runspage filterform rather than constructing a new form during reset(); - making console output conditional on DEBUG_MODE.
- reorganize imports by category;
- export MatToolTipModule so it is available to shared components for
future development;
- reorganize module structure to follow Angular recommended practices,
including:
- remove "providers" which should be provided only by CoreModule
(and already are provided there).
- remove BrowserModule import, which should only be imported by
AppModule
JSON serializers may return a single object if the SummaryRow contains only one ProblemSummaryInfo; this breaks downstream WTI-UI (Angular) components which expect an Iterable (even if there's only one item to iterate over). This avoids a problem which occurs if a contest has only one problem.
includes:
- only display score when run judgement is "Accepted".
- suuport for animation (fade-in) of score value on alert.
- uses ScoreboardModeService.
- suppression of "Run Type" on the Alert ("Run Type" is related to
whether the submission is "Test Run" or "Judged Run", a distinction
which PC2 doesn't yet support).
This reverts commit 997db29.
I1006 point scoring wti fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what the PR does
Simply merges the WTI point scoring scoreboard fixes back into the i1006 branch. A separate branch, i1006_update_prs was created to allow work to proceed by merging in some pending PR's from develop. Those PR's have since been merged into develop. As a result, we can now merge the i1006_update_prs branch into i1006_point_scoring.
Issue which the PR addresses
Partial #1006
Environment in which the PR was developed (OS,IDE, Java version, etc.)
Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)