-
Notifications
You must be signed in to change notification settings - Fork 0
View template modiifcations #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pc0202
wants to merge
3
commits into
master
Choose a base branch
from
OS-VT1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
31 changes: 31 additions & 0 deletions
31
src/main/java/io/opensaber/provider/SampleViewFunctionProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package io.opensaber.provider; | ||
|
|
||
| import io.opensaber.views.IViewFunctionProvider; | ||
| import java.util.List; | ||
| /** | ||
| * This class is a sample implementation class of IViewFunctionProvider<T> | ||
| * | ||
| */ | ||
| public class SampleViewFunctionProvider implements IViewFunctionProvider<String> { | ||
|
|
||
| @Override | ||
| public String doAction(List<Object> values) { | ||
| // doing a simple concat for the values | ||
| return concat(values); | ||
| } | ||
|
|
||
| /** | ||
| * simple concat for the values as string and comma(',') as seperator | ||
| * | ||
| * @param args | ||
| * @return | ||
| */ | ||
| public String concat(List<Object> args) { | ||
| String res = ""; | ||
| for (Object arg : args) { | ||
| res = res.toString().isEmpty() ? arg.toString() : (res + ", " + arg.toString()); | ||
| } | ||
| return res; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package io.opensaber.views; | ||
|
|
||
| public class EvaluatorFactory { | ||
|
|
||
| public static final String concat = "concat"; | ||
| public static final String userDefinedConcat = "userDefinedConcat"; | ||
| public static final String customDefinedConcat = "customDefinedConcat"; | ||
| /** | ||
| * returns the instance of IEvaluator implementations (like:FunctionEvaluator, ProviderEvaluator | ||
| * @param functionName | ||
| * @param function | ||
| * @return | ||
| */ | ||
| public static IEvaluator<Object> getInstance(String functionName, FieldFunction function){ | ||
| IEvaluator<Object> evaluator = null; | ||
| switch(functionName){ | ||
|
|
||
| case concat : | ||
| evaluator = new FunctionEvaluator(function); | ||
| break; | ||
| case userDefinedConcat : | ||
| evaluator = new ProviderEvaluator<Object>(function); | ||
| break; | ||
| case customDefinedConcat : | ||
| break; | ||
| default : | ||
| evaluator = new FunctionEvaluator(function); | ||
| break; | ||
| } | ||
|
|
||
| return evaluator; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package io.opensaber.views; | ||
|
|
||
| public interface IEvaluator<T> { | ||
| /** | ||
| * evaluates to provide result | ||
| * From a given expression, a provider class, a reference template of a sview template | ||
| * @return | ||
| */ | ||
| public T evaluate(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| package io.opensaber.views; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class ProviderEvaluator implements IEvaluator<Object> { | ||
|
|
||
| private static Logger logger = LoggerFactory.getLogger(ProviderEvaluator.class); | ||
|
|
||
| private FieldFunction function; | ||
|
|
||
| public ProviderEvaluator(FieldFunction function) { | ||
| this.function = function; | ||
| } | ||
|
|
||
| @Override | ||
| public Object evaluate() { | ||
| IViewFunctionProvider<Object> viewFuntionProvider = getInstance(function.getExpression()); | ||
| Object result = viewFuntionProvider.doAction(function.getArgValues()); | ||
| return result; | ||
| } | ||
|
|
||
| /** | ||
| * invokes instance for given providerName | ||
| * @param providerName full qualified name of class | ||
| * @return | ||
| */ | ||
| public IViewFunctionProvider<Object> getInstance(String providerName) { | ||
|
|
||
| IViewFunctionProvider<Object> viewFunctionProvider = null; | ||
| try { | ||
| if (providerName == null || providerName.isEmpty()) { | ||
| throw new IllegalArgumentException( | ||
| "view function provider class {} cannot be instantiate with empty value"); | ||
| } | ||
| Class<?> advisorClass = Class.forName(providerName); | ||
| viewFunctionProvider = (IViewFunctionProvider) advisorClass.newInstance(); | ||
| logger.info("Invoked view function provider class with classname: " + providerName); | ||
|
|
||
| } catch (ClassNotFoundException | SecurityException | InstantiationException | IllegalAccessException | ||
| | IllegalArgumentException e) { | ||
| logger.error("view function provider class {} cannot be instantiate with exception:", providerName, e); | ||
| } | ||
| return viewFunctionProvider; | ||
| } | ||
|
|
||
| } |
13 changes: 0 additions & 13 deletions
13
src/main/java/io/opensaber/views/SampleViewFunctionProvider.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MANDATORY: Why are these hardcoded here? We are creating a library and this can't be in a Factory class for sure.