Change actstream models ids type from Char to UUID#1
Open
veerat-pdgt wants to merge 4 commits intomasterfrom
Open
Change actstream models ids type from Char to UUID#1veerat-pdgt wants to merge 4 commits intomasterfrom
veerat-pdgt wants to merge 4 commits intomasterfrom
Conversation
veerat-pdgt
commented
Dec 27, 2019
actstream/models.py
Outdated
| ContentType, on_delete=models.CASCADE, db_index=True | ||
| ) | ||
| object_id = models.CharField(max_length=255, db_index=True) | ||
| object_id = models.UUIDField(max_length=255, db_index=True, default=uuid.uuid4) |
Author
There was a problem hiding this comment.
@Vaibhav015 i think we do not need to add default=uuid.uuid4
Author
There was a problem hiding this comment.
Also, why have we given max_length in uuid field ? I mean do not require this ?
There was a problem hiding this comment.
As per docs, It's recommended to use default in UUIDField @veerat-pdgt
Ref Docs: https://docs.djangoproject.com/en/3.0/ref/models/fields/#uuidfield
cc @vikalpj
Let me know your thoughts @veerat-pdgt @vikalpj 🙂
There was a problem hiding this comment.
@vaibhav-pdgt The case mentioned in doc is only applicable when we have PK for uuid. else default should always be based on the usecase. :)
Author
|
Changes LGTM @vaibhav-pdgt |
vikalpj
force-pushed
the
vs_change_char_to_uuids
branch
from
6e43309 to
ab362d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change actstream models ids type from Char to UUID
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)