Skip to content

Conversation

@jo-basevi
Copy link
Collaborator

This PR changes the default setting of sync to exclude_uncollated files to always False.

See related issue #648

@jo-basevi jo-basevi force-pushed the 648-default-exclude-uncollated-false branch from 2bdcfb1 to cc20b8b Compare December 12, 2025 00:32
@coveralls
Copy link

Coverage Status

coverage: 60.273% (+0.1%) from 60.167%
when pulling cc20b8b on ACCESS-NRI:648-default-exclude-uncollated-false
into 5292c9f on payu-org:master.

@jo-basevi jo-basevi marked this pull request as ready for review December 14, 2025 22:32
@jo-basevi jo-basevi changed the title payu sync: Default exclude_uncollated to true payu sync: Default exclude_uncollated to false Dec 15, 2025
@jo-basevi
Copy link
Collaborator Author

Tested with a configuration with collation disabled for a run so there was uncollated files, then checked --exclude *.nc.* was added to rsync commands when exclude_uncollated: true, and no --exclude *.nc.* was added when collation was re-enabled, and exclude_uncollated setting was removed, and all previous uncollated files were synced.

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jo-basevi jo-basevi merged commit d042ac0 into payu-org:master Dec 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants