-
Notifications
You must be signed in to change notification settings - Fork 12
Allow Ruby 3.4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mathieujobin anything I need to do to restart the checks? |
|
Thanks for opening this PR @joe-sharp Sorry this falls on you, but if you could look through the failures. it looks like Thanks |
|
@mathieujobin I think my most recent commit should work, based on what I read in rails/rails#54271 anyway. Mind retriggering the tests when you have a chance? Thanks in advance! |
|
Sorry for the retest and delay @mathieujobin . I finally got a chance to get all the Ruby versions installed and tested each of the iterations locally. We should be good to go unless CI does something I didn't notice. |
|
Dah, wrote yesterday but unsent ....
Full disclosure, hiding is for weeps. Merged and tagged, about to push to rubygems |
|
@mathieujobin not sure why but RubyGems never seemed to get the new version |
This pull request adjusts its Ruby version compatibility to allow and test Ruby 3.4
Ruby version compatibility updates:
.github/workflows/tests.yml: Added Ruby 3.4 to the matrix of supported versions for testing.dynamic_form.gemspec: Updatedrequired_ruby_versionto allow Ruby versions up to 3.4.Version updates:
VERSION: Removed this legacy filedynamic_form.gemspec: Incremented the gem version from1.3.1to1.3.2.