Skip to content

Conversation

@joe-sharp
Copy link

@joe-sharp joe-sharp commented Jun 20, 2025

This pull request adjusts its Ruby version compatibility to allow and test Ruby 3.4

Ruby version compatibility updates:

Version updates:

@joe-sharp
Copy link
Author

@mathieujobin anything I need to do to restart the checks?

@mathieujobin
Copy link

Thanks for opening this PR @joe-sharp
Looks like tests are running again, now that it is set to ubuntu 22.04

Sorry this falls on you, but if you could look through the failures.

it looks like logger and maybe also Logger::Severity needs to be required explicitly.
Maybe others too.

Thanks

@joe-sharp
Copy link
Author

@mathieujobin I think my most recent commit should work, based on what I read in rails/rails#54271 anyway. Mind retriggering the tests when you have a chance? Thanks in advance!

@joe-sharp
Copy link
Author

Sorry for the retest and delay @mathieujobin . I finally got a chance to get all the Ruby versions installed and tested each of the iterations locally. We should be good to go unless CI does something I didn't notice.

@mathieujobin mathieujobin merged commit f9ddd3b into payrollhero:master Jun 28, 2025
20 checks passed
@mathieujobin
Copy link

Dah, wrote yesterday but unsent ....

Thanks a lot, I meant to merge this hours ago, couldn't process much today

This gem probably needs a new maintainer, I did not know anyone else was using it. and I am not using it anymore ... so ...

for a while I had fun getting ownership over too many gems https://rubygems.org/profiles/mathieu

Full disclosure, hiding is for weeps.

Merged and tagged, about to push to rubygems

@joe-sharp
Copy link
Author

joe-sharp commented Jul 12, 2025

@mathieujobin not sure why but RubyGems never seemed to get the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants