Skip to content

Refactor to fix warnings around frozen strings #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CloCkWeRX wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor to fix warnings around frozen strings #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b812b
Refactor how string is built, so its a ActiveSupport::SafeBuffer.new …
CloCkWeRX Aug 3, 2025
bd06e36
Opt in to frozen string literals, as we are no longer mutating a string
CloCkWeRX Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/action_view/helpers/dynamic_form.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'action_view/helpers'
require 'active_support/i18n'
require 'active_support/core_ext/enumerable'
Expand Down Expand Up @@ -234,12 +236,12 @@ def error_messages_for(*params)
end
end.inject(:+).join.html_safe

contents = ''
contents = ''.html_safe
contents << content_tag(options[:header_tag] || :h2, header_message) unless header_message.blank?
contents << content_tag(:p, message) unless message.blank?
contents << content_tag(:ul, error_messages)

content_tag(:div, contents.html_safe, html)
content_tag(:div, contents, html)
end
else
''
Expand Down