Skip to content

Style/ExpandPathArguments-20230517233328 #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Style/ExpandPathArguments-20230517233328 #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e30b1c
:police_car: regenerate rubocop todo
May 17, 2023
8fce2a7
:police_car: Style/ExpandPathArguments
May 17, 2023
5d5d80c
:police_car: regenerate rubocop todo
May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config --exclude-limit 180`
# on 2023-04-20 23:33:11 UTC using RuboCop version 1.50.2.
# on 2023-05-17 23:33:53 UTC using RuboCop version 1.51.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -415,13 +415,6 @@ Style/ClassVars:
Exclude:
- 'lib/dispatch-rider/publisher/base.rb'

# Offense count: 5
# This cop supports safe autocorrection (--autocorrect).
Style/ExpandPathArguments:
Exclude:
- 'lib/generators/dispatch_rider/install/install_generator.rb'
- 'lib/generators/dispatch_rider/job/dispatch_job_generator.rb'

# Offense count: 26
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/dispatch_rider/install/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module DispatchRider
class InstallGenerator < ::Rails::Generators::Base
source_root File.expand_path("../templates", __FILE__)
source_root File.expand_path('templates', __dir__)

def create_scripts
copy_file "script/dispatch_rider", "script/dispatch_rider"
Expand Down
8 changes: 4 additions & 4 deletions lib/generators/dispatch_rider/job/dispatch_job_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

class DispatchJob < Rails::Generators::Base
class Publisher < Rails::Generators::Base
source_root File.expand_path('../templates/publisher', __FILE__)
source_root File.expand_path('templates/publisher', __dir__)
argument :handler_name, type: :string, required: true
argument :publisher_name, type: :string, required: true

class Rspec < Rails::Generators::Base
source_root File.expand_path('../templates/publisher', __FILE__)
source_root File.expand_path('templates/publisher', __dir__)
argument :handler_name, type: :string, required: true
argument :publisher_name, type: :string, required: true

Expand All @@ -24,11 +24,11 @@ def generate_publisher
end

class Handler < Rails::Generators::Base
source_root File.expand_path('../templates/handler', __FILE__)
source_root File.expand_path('templates/handler', __dir__)
argument :handler_name, type: :string, required: true

class Rspec < Rails::Generators::Base
source_root File.expand_path('../templates/handler', __FILE__)
source_root File.expand_path('templates/handler', __dir__)
argument :handler_name, type: :string, required: true

def generate_handler_spec
Expand Down