Expose an option to list all devices and create camera from selected one#13
Open
mrozycki wants to merge 1 commit intopayload:mainfrom
Open
Expose an option to list all devices and create camera from selected one#13mrozycki wants to merge 1 commit intopayload:mainfrom
mrozycki wants to merge 1 commit intopayload:mainfrom
Conversation
mrozycki
force-pushed
the
list-devices
branch
from
d1bde34 to
087ccda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a
Devicestruct in all 3 backends, allowing the user of the library to get a list of all available devices, and create aCameraout of a selected one. Tested it on macOS, Windows and Linux.I've had some issues with winit on Linux, even without my changes, so I did a minimal amount of work to update winit to 0.30.5 locally to test my changes. I did not include that in this PR, but I might do it separately. Generally, since winit is only used in the example code, this is not high priority in my opinion.