Skip to content

Revert/kyb daily estimated volume#696

Merged
onahprosper merged 2 commits intomainfrom
revert/kyb-daily-estimated-volume
Feb 19, 2026
Merged

Revert/kyb daily estimated volume#696
onahprosper merged 2 commits intomainfrom
revert/kyb-daily-estimated-volume

Conversation

@SarahSync
Copy link
Collaborator

@SarahSync SarahSync commented Feb 19, 2026

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, contracts etc.

References

Include any links supporting this change such as a:

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this project has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

Summary by CodeRabbit

  • Breaking Changes
    • Removed the DailyEstimatedVolume field from KYB (Know Your Business) submission and document response APIs. This field is no longer accepted in submission requests or included in API responses.

…ated-volume"

This reverts commit 64acef0, reversing
changes made to d157c75.
- Removed the "daily_estimated_volume" column from the "kyb_profiles" table to streamline the schema.
- Updated migration files to reflect this change, ensuring the database structure is aligned with the latest requirements.
@cursor
Copy link

cursor bot commented Feb 19, 2026

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 26.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes the DailyEstimatedVolume field from the KYB profile system across all layers: entity definitions, database schema, generated code, controller logic, and API types. A database migration drops the corresponding column from the kyb_profiles table.

Changes

Cohort / File(s) Summary
Entity & Generated Code
ent/kybprofile.go, ent/kybprofile/kybprofile.go, ent/kybprofile/where.go, ent/kybprofile_create.go, ent/kybprofile_update.go, ent/schema/kybprofile.go, ent/mutation.go, ent/runtime/runtime.go
Removed DailyEstimatedVolume field definition, struct field, setters, getters, query predicates, update/create builders, and mutation handling across all ent-generated code layers.
API & Controllers
controllers/index.go, controllers/index_test.go, types/types.go
Removed DailyEstimatedVolume from KYB submission input handling, response payloads, and test fixtures; eliminated field writes in controller logic.
Database Schema & Migrations
ent/migrate/migrations/20260218105934_add_daily_estimated_volume.sql, ent/migrate/migrations/20260219103600_drop_daily_estimated_volume.sql, ent/migrate/schema.go
Removed the add migration, added drop migration to remove column from kyb_profiles table, and updated schema column references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Suggested reviewers

  • chibie
  • 5ran6
  • onahprosper

Poem

🐰 A field once lived in KYB's domain,
Daily volumes it did contain,
But now we've swept it all away,
Migrations drop it without delay,
Cleaner schemas hop and play! 🌱

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert/kyb-daily-estimated-volume

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@onahprosper onahprosper merged commit 6adaad4 into main Feb 19, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save previous provider rates in priority queue to reduce order failures

2 participants

Comments