CHAINS-6848 Merge upstream/master for btc testnet4 changes#11
Merged
rahul-aravind-opti merged 171 commits intomasterfrom Nov 10, 2025
Merged
CHAINS-6848 Merge upstream/master for btc testnet4 changes#11rahul-aravind-opti merged 171 commits intomasterfrom
rahul-aravind-opti merged 171 commits intomasterfrom
Conversation
Fixes btcsuite#2199. Previous to this fix the keytype was only interpreted as a single byte, even though BIP-0174 states it is to be parsed as a CompactSize/VarInt.
This commit updates the error str to match the same error returned from `btcd` for both pre-0.24.2 and post-0.24.2.
psbt: decode keytype as compact size
Sending RPC requests through unix sockets
commit 0b2998b Author: cec489 <173723251+cec489@users.noreply.github.com> Date: Mon Jun 24 20:01:13 2024 +0000 A cleaner fix is to set the startTime in the server Start() function which is where the server is actually started. commit ae6c125 Author: cec489 <173723251+cec489@users.noreply.github.com> Date: Mon Jun 24 19:15:23 2024 +0000 Fix the btcctl uptime command by moving the setting of startupTime
This change lets us test that we don't attempt to delete open files with unit tests. On Windows this behavior is not allowed which results in an error but on linux and osx it's allowed. To better test Windows compatibilty adding this explicit check in is useful.
This check let's us ensure that attempting to delete open files are caught during unit tests.
The existing file close code is refactored out into it's own method closeFile() so that it can be reused elsewhere.
The block files may be open when deleteFile is called. This resulted in files not being deleted and erroring out on windows. Properly closing the files closing the files avoids this error.
…lockfiles ffldb: close block files
Signed-off-by: linghuying <1599935829@qq.com>
mod+rpcserver: bump to latest version of btcec
It is undefined behavior if we directly use the value from a Get call after the transaction has completed.
blockchain: copy utxo status bytes to avoid UB
Signed-off-by: lencap <techgeek@189.cn>
synchronize dependencies
…marx-cve Updated btcd dependency of btcutil to address CVE-2024-34478
wire: check TXID length before creating outpoint
rpcclient: signet support
Fixes btcsuite#2224 and lightningnetwork/lnd#9053. Depending on the version of Bitcoin Core, the "warnings" field in the response to getnetworkinfo is either a single string value or an array of strings. We can easily parse those two variants with a custom type that implements an UnmarshalJSON method.
btcjson: turn warnings into StringOrArray type
Signed-off-by: huochexizhan <huochexizhan@outlook.com>
Formatting code with gofmt
chore: fix some comments
wire: optimize parsing for CFCheckpkt message, reduce allocs by 96%
…e-guide .gemini: add `styleguide.md`
Align hash function count with bloom filter capacity
btcjson: add stubs for SubmitPackage
Fixes btcsuite#2404. If different versions of bitcoind return different error strings, we need a way to match those as well.
rpcclient: add bitcoind version dependent error matching
feat: fix ci / makefile
Dockerfile: update go base image
Co-authored-by: Oliver Gugger <gugger@gmail.com>
…ATH-bin-dir Makefile+workflows: fallback to `GOPATH/bin` on non-existent `GOBIN`
build: bump version to v0.25.0-beta.rc1
This commit adds a new function to musig2.Session, which allows the caller to add an external aggregated nonce to the session.
…once musig2: add WithExternalCombinedNonce option to Sign
Ensure that the dial phase of rpcclient's HTTP posts respects the http.Client's Timeout. It was instead falling back to the OS settings.
build: bump version to v0.25
…correct-dialcontext rpcclient: ensure http dial respects timeout
Resolved merge conflicts: - .gitignore: Combined Goland settings with upstream .DS_Store and .aider* entries - rpcclient/infrastructure.go: Merged ObservingTransport wrapper with ParseAddressString Unix socket support and HTTP timeout 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bmperrea
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps:
Fixed the merge conflicts with claude