Skip to content

Add timeouts for transport layer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwortmanp wants to merge 2 commits into
base: renameMethod
Choose a base branch
from
Open

Add timeouts for transport layer #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6070d5e
Add timeouts for transport layer
mwortmanp Sep 22, 2025
67dcc1b
remove comment
mwortmanp Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions rpcclient/infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1356,17 +1356,27 @@ func newHTTPClient(config *ConnConfig) (*http.Client, error) {
}
}

transport := &ObservingTransport{
Base: &http.Transport{
Proxy: proxyFunc,
TLSClientConfig: tlsConfig,
},
baseTransport := http.Transport{
Proxy: proxyFunc,
TLSClientConfig: tlsConfig,
}

baseTransport.DialContext = (&net.Dialer{
Timeout: 3 * time.Second,
KeepAlive: 30 * time.Second,
}).DialContext
baseTransport.TLSHandshakeTimeout = 3 * time.Second
baseTransport.ResponseHeaderTimeout = 10 * time.Second

observingTransport := &ObservingTransport{
Base: &baseTransport,
// Wrap with response capturing if callback provided
OnResponseCapture: config.OnResponseCapture,
}

client := http.Client{
Transport: transport,
Transport: observingTransport,
Timeout: 30 * time.Second, // Overall request timeout
Comment on lines +1364 to +1379
Copy link

@seanag0234 seanag0234 Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want a way to pass the timeout value in, since we have the concept of an RPC timeout. This should be super nice.

}

return &client, nil
Expand Down