Fix build failure: remove macOS-only linker flag and unused slug depe…#12
Merged
paulosuzart merged 1 commit intofix/handle-git-errorsfrom Mar 16, 2026
Merged
Conversation
…ndency The root dune file added in PR #11 used -Wl,-no_warn_duplicate_libraries, a macOS-specific linker flag not recognized by GNU ld on Linux (ubuntu CI). This caused dune build to fail with a linker error on ubuntu-22.04. Also removes the stale `slug` dependency from dune-project and starred_ml.opam since the code no longer uses it (removed in v0.0.7 but not cleaned up from deps). https://claude.ai/code/session_01FMvB6gQZy7SaksbRDc9ETC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndency
The root dune file added in PR #11 used -Wl,-no_warn_duplicate_libraries, a macOS-specific linker flag not recognized by GNU ld on Linux (ubuntu CI). This caused dune build to fail with a linker error on ubuntu-22.04.
Also removes the stale
slugdependency from dune-project and starred_ml.opam since the code no longer uses it (removed in v0.0.7 but not cleaned up from deps).https://claude.ai/code/session_01FMvB6gQZy7SaksbRDc9ETC