Feature de calculo de notas(incompleto), e de cadastro de turma

[pglj2]

Só foi feito 4 cenários, sendo 2 de GUI e 2 de Controlador

---

This change is 

[pauloborba]

Reviewed 6 of 15 files at r1.
Review status: 6 of 15 files reviewed at latest revision, 15 unresolved discussions.

---

grails-app/domain/ta/Class.groovy, line 5 at r1 (raw file):

class Class {
    String classID
    String periodo

deveria ter o ano também

---

grails-app/domain/ta/Class.groovy, line 6 at r1 (raw file):

    String classID
    String periodo
    List students

nao precisaria ser uma lista ja que a ordem nao importa

---

test/cucumber/AddClass.feature, line 7 at r1 (raw file):

#Controller scenario
  Scenario: new class

básico demais

---

test/cucumber/AddClass.feature, line 15 at r1 (raw file):

  Scenario: new class with duplicate name and periodo
    Given the system already has a class with ID "PLC" and period "2017.1"
    When I add a class with name "PLC" and period "2016.1"

name ou ID? basico demais. esquisito nao deixar ter PLC 2016.1 e 2017.1! isso é necessário! faltou conversar com o stakeholder

---

test/cucumber/AddClass.feature, line 20 at r1 (raw file):

#GUI scenario
  Scenario: new class gui
    Given I am at the Create Class page

deveria ter confirmado que nao existe. baixo nivel

---

test/cucumber/AddClass.feature, line 30 at r1 (raw file):

    Given the system already has a class with name "PLC" and period "2017.2"
    And I am at the Create Class page
    When I fill in the class details with name "PLC" and period "2017.2"

baixo nivel

---

test/cucumber/CalcGrades.feature, line 1 at r1 (raw file):

### Created by Avell at 13/06/2017

por que comentado?

---

test/cucumber/steps/AddClassSteps.groovy, line 73 at r1 (raw file):

        at CreateClassPage
        page.fillClassDetails(id, periodo)
        page.selectCreateClass()

deveria verificar que foi criada

---

test/cucumber/steps/CalcGrades.groovy, line 2 at r1 (raw file):

package steps

por que vazio?

---

test/functional/pages/ClassPages/CreateClassPage.groovy, line 11 at r1 (raw file):

    static at = {
        title ==~ /Create Class/

dependente de plataforma

---

test/functional/pages/ClassPages/CreateClassPage.groovy, line 24 at r1 (raw file):

    def boolean checkForErrors() {
        return $("ul", class: "errors").isDisplayed()

verificacao superficial

---

test/functional/pages/ClassPages/TurmasPage.groovy, line 15 at r1 (raw file):

    }

    def assertClass(id, periodo){

vazio???

---

test/functional/pages/ClassPages/TurmasPage.groovy, line 27 at r1 (raw file):

        boolean findTurma = $("tr").has("td", text: periodo).find("td").has("a", text: id)

        if (findTurma) {

refatorar

---

test/functional/steps/ClassTestDataAndOperations.groovy, line 19 at r1 (raw file):

    public static Class get_Class(String id, String periodo) {
        def controller = new ClassController()

poderia ter sido direto via modelo

---

test/functional/steps/ClassTestDataAndOperations.groovy, line 30 at r1 (raw file):

    public static boolean onlyClass(String id, String period){
        def cont = new ClassController()

poderia ser direto via modelo

---

Comments from Reviewable